Feature/resource base locator #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource base is different depending on the virtual host. Since the symfony project is used for several virtual hosts, the base path of the resources cannot be stored in the dependency container cache and must be determined at runtime.
The base path for the resources cannot be set as a ResourceLoader argument. The reason for this is that the ResourceLoader is also configured as a service in Symfony projects. The same Symfony project is used for several virtual hosts. As the services and their arguments are cached, the resource base paths would be the same for all virtual hosts, which is not correct. Therefore, the resource base path must always be determined dynamically, e.g. using a server variable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 71 77 +6
===========================================
Files 7 10 +3
Lines 238 259 +21
===========================================
+ Hits 238 259 +21 ☔ View full report in Codecov by Sentry. |
sitepark-schaeper
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base path for the resources cannot be set as a ResourceLoader argument. The reason for this is that the ResourceLoader is also configured as a service in Symfony projects. The same Symfony project is used for several virtual hosts. As the services and their arguments are cached, the resource base paths would be the same for all virtual hosts, which is not correct. Therefore, the resource base path must always be determined dynamically, e.g. using a server variable.