-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/initial implementation #1
Conversation
…rvice::getAvailableIndices
Co-authored-by: Mario Schäper <95750382+sitepark-schaeper@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, just a couple small things remaining
obsolete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this comment from earlier on?:
For the big constructors (especially) it's probably usefull to use named arguments. Compare the following:
$this->status = new IndexerStatus(
IndexerStatusState::RUNNING,
new DateTime(),
null,
$total,
0,
0,
new DateTime(),
0,
0
);
$this->status = new IndexerStatus(
state: IndexerStatusState::RUNNING,
startTime: new DateTime(),
endTime: null,
total: $total,
processed: 0,
skipped: 0,
lastUpdate: new DateTime(),
updated: 0,
errors: 0
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a couple more instances where named arguments are probably worth using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Included in #3 |
Initial implementation of the atoolo search.