Merge branch 'main' into dependabot/maven/org.junit-junit-bom-5.10.2

sitepark · Feb 6, 2024 · 4c080d7 · 4c080d7
2 parents cdadbf5 + 3d35aeb
commit 4c080d7
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 1 deletion.
diff --git a/src/main/java/com/sitepark/ies/userrepository/core/domain/entity/Identifier.java b/src/main/java/com/sitepark/ies/userrepository/core/domain/entity/Identifier.java
@@ -96,7 +96,7 @@ public boolean equals(Object o) {
 	@Override
 	public String toString() {
 		if (this.id != null) {
-			return this.id.toString();
+			return this.id;
 		}
 		return this.anchor.toString();
 	}

diff --git a/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/AccessTokenTest.java b/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/AccessTokenTest.java
@@ -21,9 +21,14 @@
 import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
 @SuppressWarnings("PMD.TooManyMethods")
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL"
+})
 class AccessTokenTest {
 
 	private static final ZoneId ZONE_ID = ZoneId.of( "Europe/Berlin" );

diff --git a/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/IdentifierTest.java b/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/IdentifierTest.java
@@ -7,8 +7,13 @@
 
 import org.junit.jupiter.api.Test;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL"
+})
 class IdentifierTest {
 
 	@Test

diff --git a/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/RoleTest.java b/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/RoleTest.java
@@ -11,6 +11,10 @@
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL"
+})
 class RoleTest {
 
 	private static final String TEST_ROLE_NAME = "ADMINISTRATOR";

diff --git a/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/UserTest.java b/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/UserTest.java
@@ -20,13 +20,19 @@
 import com.sitepark.ies.userrepository.core.domain.entity.role.Ref;
 import com.sitepark.ies.userrepository.core.domain.entity.role.UserLevelRoles;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
 @SuppressWarnings({
 	"PMD.AvoidDuplicateLiterals",
 	"PMD.TooManyMethods",
 	"PMD.GodClass"
 })
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL",
+	"NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS"
+})
 class UserTest {
 
 	private static Identity TEST_IDENTITY = LdapIdentity.builder()

diff --git a/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/UserValidityTest.java b/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/UserValidityTest.java
@@ -19,13 +19,18 @@
 import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
 @SuppressWarnings({
 	"PMD.JUnitTestContainsTooManyAsserts",
 	"PMD.AvoidDuplicateLiterals",
 	"PMD.TooManyMethods"
 })
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL"
+})
 class UserValidityTest {
 
 	private static final ZoneId ZONE_ID = ZoneId.of( "Europe/Berlin" );

diff --git a/...st/java/com/sitepark/ies/userrepository/core/domain/entity/identity/LdapIdentityTest.java b/...st/java/com/sitepark/ies/userrepository/core/domain/entity/identity/LdapIdentityTest.java
@@ -11,9 +11,14 @@
 import com.fasterxml.jackson.databind.module.SimpleModule;
 import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
 @SuppressWarnings("PMD.TooManyMethods")
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL"
+})
 class LdapIdentityTest {
 
 	private static final String USER_DN = "userdn";

diff --git a/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/role/RefTest.java b/src/test/java/com/sitepark/ies/userrepository/core/domain/entity/role/RefTest.java
@@ -9,8 +9,13 @@
 
 import com.sitepark.ies.userrepository.core.domain.entity.Anchor;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import nl.jqno.equalsverifier.EqualsVerifier;
 
+@SuppressFBWarnings({
+	"PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES",
+	"NP_NULL_PARAM_DEREF_NONVIRTUAL"
+})
 class RefTest {
 
 	@Test