Skip to content

Commit

Permalink
Adapt demo mode and the standard steps for app access based on port f…
Browse files Browse the repository at this point in the history
…orwarding
  • Loading branch information
ssorj committed Mar 7, 2024
1 parent 51ebef5 commit 36fbfc5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ _**West:**_

~~~ shell
skupper delete
kubectl delete service/frontend
kubectl delete deployment/frontend
~~~

Expand Down
6 changes: 2 additions & 4 deletions python/skewer/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,8 @@ def pause_for_demo(model):

if first_site.platform == "kubernetes":
with first_site:
if resource_exists("service/frontend"):
if get_resource_json("service/frontend", ".spec.type") == "LoadBalancer":
frontend_host = await_ingress("service/frontend")
frontend_url = f"http://{frontend_host}:8080/"
if resource_exists("deployment/frontend"):
frontend_url = f"http://localhost:8080/"

if resource_exists("secret/skupper-console-users"):
console_host = await_ingress("service/skupper")
Expand Down
1 change: 0 additions & 1 deletion python/skewer/standardsteps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ hello_world/cleaning_up:
commands:
"0":
- run: skupper delete
- run: kubectl delete service/frontend
- run: kubectl delete deployment/frontend
"1":
- run: skupper delete
Expand Down

0 comments on commit 36fbfc5

Please sign in to comment.