Use joined errors #1610
Open
Use joined errors #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.20 added support for joined errors; using those instead of error slices allows typical nil/non-nil semantics to be used, and allows all error messages to be shown simultaneously when asserting. This gets rid of HandleErrorList, and with it the implied generic/validation error distinction. To handle that, HandleError takes an additional error type parameter, making the distinction explicit. Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 added support for joined errors; using those instead of error slices allows typical nil/non-nil semantics to be used, and allows all error messages to be shown simultaneously when asserting.