Update Network Observer API Route Slash Conventions #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the network-observer API had opted to include trailing slashes in resource URIs (e.g. `sites/`) and had 301 redirects from `sites` to `sites/`. This change reverses the previous convention. Now the API prefers `sites` over `sites/`, and will redirect from the later to the former. Signed-off-by: Christian Kruse <christian@c-kruse.com>
c-kruse
added a commit
to c-kruse/skupper
that referenced
this pull request
Dec 13, 2024
…roject#1837)" This reverts commit a7f0eb8. Certain browser cache conditions can lead to redirect loop.
c-kruse
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the network-observer API had opted to include trailing slashes in resource URIs (e.g.
sites/) and had 301 redirects fromsitestosites/. This change reverses the previous convention. Now the API preferssitesoversites/, and will redirect from the later to the former.Closes #1836