Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for nonkube site delete --all option #1851

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

lynnemorrison
Copy link
Collaborator

No description provided.

@@ -85,6 +91,28 @@ func (cmd *CmdSiteDelete) Run() error {
if err != nil {
return err
}
// if delete all, also remove all the other resources
if cmd.all {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there are AccessTokens or Links to other sites?
Would it be fair to remove all resources from the input/resources instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the following to see what is created in which directory:

skupper site create west -p podman -n west --enable-link-access --bind-host 127.0.0.1
skupper listener create backend 8080 -n west
skupper system setup -n west

Sources will be consumed from namespace "west"
2024/12/18 09:15:13 updating listener west/backend...
It is recommended to enable lingering for lmorrison, otherwise Skupper may not start on boot.
Site "west" has been created on namespace "west"
Platform: podman
Static links have been defined at: /home/lmorrison/.local/share/skupper/namespaces/west/runtime/links
Definition is available at: /home/lmorrison/.local/share/skupper/namespaces/west/input/resources

[lmorrison@localhost v2_skupper]$ ls /home/lmorrison/.local/share/skupper/namespaces/west/input/resources
listeners routerAccesses sites
[lmorrison@localhost v2_skupper]$ ls /home/lmorrison/.local/share/skupper/namespaces/west/runtime/links
link-router-access-west-127.0.0.1.yaml

I might be missing something but I only see the three resources that I created with the CLI in input/resources,
should I also see other items there? like links? Should I delete the links in runtime/links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants