Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the bootstrap script to accept a custom path when using the cli image #1874

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

Fixed the bootstrap script to accept a custom path when using the cli image #1874

wants to merge 2 commits into from

Conversation

fgiorgetti
Copy link
Member

No description provided.

@fgiorgetti fgiorgetti requested a review from nluaces January 10, 2025 20:31
@fgiorgetti
Copy link
Member Author

@nluaces I had to include an extra commit here to ensure that the container endpoint to be used
matches the seletect platform on bootstrap and the runtime platform (ignoring the --platform or the
environment variable) on teardown. It seems to work for me. Let me know if you can spot any issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajssmith ajssmith ajssmith approved these changes

@grs grs grs approved these changes

@c-kruse c-kruse Awaiting requested review from c-kruse

@nluaces nluaces Awaiting requested review from nluaces

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fgiorgetti @grs @ajssmith @nluaces