Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace hard-coded state secret in examples and docs with use of an environment variable #2220

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 28, 2024

fixes #1268

@filmaj filmaj added the docs M-T: Documentation work only label Aug 28, 2024
@filmaj filmaj requested review from lukegalbraithrussell and a team August 28, 2024 16:30
@filmaj filmaj self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (6842a1b) to head (6a912fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files          19       19           
  Lines        1646     1646           
  Branches      464      464           
=======================================
  Hits         1343     1343           
  Misses        194      194           
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, otherwise looks great!

filmaj and others added 2 commits August 28, 2024 13:02
Co-authored-by: Luke Russell <31357343+lukegalbraithrussell@users.noreply.github.com>
Co-authored-by: Luke Russell <31357343+lukegalbraithrussell@users.noreply.github.com>
@filmaj filmaj merged commit ffabf3c into main Aug 28, 2024
17 checks passed
@filmaj filmaj deleted the state-secret-env-var-docs branch August 28, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encourage using an env variable for stateSecret in documents
2 participants