Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Strip protocol before feeding just the outgoing domain to the manifest API #246

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Assume http protocol for inputs that have just the host name, and imp…

b584112
Select commit
Loading
Failed to load commit list.
Open

fix(manifest): Strip protocol before feeding just the outgoing domain to the manifest API #246

Assume http protocol for inputs that have just the host name, and imp…
b584112
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 21, 2023 in 0s

97.95% (-0.12%) compared to ca8e418

View this Pull Request on Codecov

97.95% (-0.12%) compared to ca8e418

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ca8e418) 98.07% compared to head (b584112) 97.95%.

Files Patch % Lines
src/manifest/mod.ts 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   98.07%   97.95%   -0.12%     
==========================================
  Files          58       58              
  Lines        2280     2301      +21     
  Branches      137      140       +3     
==========================================
+ Hits         2236     2254      +18     
- Misses         42       45       +3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.