Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifest): Strip protocol before feeding just the outgoing domain to the manifest API #246

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+92 −2
Open

fix(manifest): Strip protocol before feeding just the outgoing domain to the manifest API #246

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ccea37
Strip protocol before feeding just the outgoing domain to the manifes…
arunsathiya Nov 20, 2023
2cff6ca
Refactor into a validateOutgoingDomains helper function and create te…
arunsathiya Nov 21, 2023
e949928
Merge branch 'main' into fix/manifest-outgoing-domains
arunsathiya Nov 21, 2023
8c9ade2
Return domain as is if the input doesn't have a protocol
arunsathiya Nov 21, 2023
b584112
Assume http protocol for inputs that have just the host name, and imp…
arunsathiya Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/manifest/mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,13 @@ export class SlackManifest {
);
}

manifest.outgoing_domains = def.outgoingDomains || [];
manifest.outgoing_domains = (def.outgoingDomains || []).map((domain) => {
try {
return new URL(domain).hostname;
} catch (e) {
throw new Error(`Invalid outgoing domain: ${domain}, error ${e}`);
}
});

// Assign remote hosted app properties
if (manifest.settings.function_runtime === "slack") {
Expand Down