Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_OUTPUT envvar instead of set-output command as the latter is deprecated #261

Merged

Conversation

arunsathiya
Copy link
Contributor

@arunsathiya arunsathiya commented Dec 26, 2023

Summary

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

Testing

  • I think the next publish action should successfully go through?

Special notes

I have scanned all repositories owned by slackapi (thanks to gh-clone-org extension from this issue) and there is only one instance of usage.

It's set-output on the npm-publish workflow for deno-slack-sdk repository.

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

…is deprecated

Signed-off-by: Arun <arun@arun.blog>
@arunsathiya arunsathiya requested a review from a team as a code owner December 26, 2023 09:03
- name: Setup Deno
uses: denoland/setup-deno@v1
with:
deno-version: v1.x

- name: Get the tag name
id: get_tag_name
run: echo ::set-output name=TAG::${GITHUB_REF#refs/*/}

run: echo "TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change being proposed in this PR. The rest of the changes are formatting corrections made by my IDE.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca8e418) 98.07% compared to head (34feb7c) 98.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          58       58           
  Lines        2280     2280           
  Branches      137      137           
=======================================
  Hits         2236     2236           
  Misses         42       42           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@filmaj filmaj merged commit 4791d00 into slackapi:main Jan 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants