Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readme to denoland #264

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

This PR aim to allow denoland to display the readme.md from this repository while maintaining a single source of truth for the readme

Testing

Test this out from this branch

Special notes

This change moves the README.md content to src/README.md and creates a symbolic link between README.md and src/README.md, this makes src/README.md the source of truth but allows GitHub to properly render the README.md file

I took this approach from the next.js project

Feedback

  • Is this something we want to implement?
  • Is there a simpler way to do this?
  • Could this cause confusion in the future?

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've ran deno task test after making the changes.

@WilliamBergamin WilliamBergamin added the documentation Improvements or additions to documentation label Jan 8, 2024
@WilliamBergamin WilliamBergamin self-assigned this Jan 8, 2024
@WilliamBergamin WilliamBergamin requested a review from a team as a code owner January 8, 2024 16:27
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good approach

@WilliamBergamin WilliamBergamin merged commit 5413c43 into main Jan 8, 2024
9 checks passed
@WilliamBergamin WilliamBergamin deleted the add-readme-to-denoland branch January 8, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants