Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify built-in function generation for dev and/or behind-toggle functions #297

Closed
wants to merge 2 commits into from

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Mar 21, 2024

Clarifying use of the generation script for dev and/or feature-flagged function definitions.

@filmaj filmaj added the documentation Improvements or additions to documentation label Mar 21, 2024
@filmaj filmaj self-assigned this Mar 21, 2024
@filmaj filmaj requested a review from a team as a code owner March 21, 2024 16:30
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (3a9332a) to head (ffc6537).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          63       63           
  Lines        2552     2552           
  Branches      147      147           
=======================================
  Hits         2510     2510           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WilliamBergamin WilliamBergamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks for improving this 💯

@filmaj
Copy link
Contributor Author

filmaj commented Mar 22, 2024

We apparently don't want to publicly expose the fact we use feature flags. Woopsie! Hopefully no one is paying attention.

@filmaj filmaj closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants