Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add color #64

wants to merge 3 commits into from

Conversation

typiconman
Copy link
Contributor

Add documentation about defining a custom kinovar color. @pgmmpk please review.

@typiconman typiconman requested a review from pgmmpk August 9, 2020 17:51
Copy link
Collaborator

@pgmmpk pgmmpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to issue a new version of fonts-churchslavonic package first. See other comments inline.

@@ -7,6 +7,7 @@
\newfontfamily\russianfontsf[Ligatures=TeX]{lmsans10-regular.otf}
\newfontfamily\churchslavonicfont[Script=Cyrillic,Ligatures=TeX,Scale=MatchLowercase,HyphenChar=_]{PonomarUnicode.otf}
\newfontfamily\musicFont[Scale=1.5]{MezenetsUnicode}
\newfontfamily\demestvo[Scale=1.5,StylisticSet=2]{MezenetsUnicode}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this font is not in fonts-churchslavonic, this will not compile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this is the font for Znamenny Notation, and it is not part of the package yet.

@@ -17,7 +18,7 @@
pdfkeywords={Church Slavonic, Old Church Slavonic, Church Slavic, Znamenny Notation, LaTeX, TeX, XeTeX, LuaTeX, OpenType, Unicode, церковнославянский, старославянский, знаменная нотация, крюки, столповая нотация}
]{hyperref}

\def\fileversion{0.4}
\def\fileversion{0.2.2}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File version jumps back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Strange. I wonder what happened.

@pgmmpk
Copy link
Collaborator

pgmmpk commented Aug 10, 2020

All good. Need to keep in mind that before releasing this to CTAN we need to release new version of fonts-churchslavonic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants