LinuxKMS: Fix support for triple buffering with DRM #7299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the drm output now waiting for the page flip on render *and* gbm and dumb buffer displays supporting triple buffering, we don't need the entire async page flip handling logic anymore. In the future we could turn wait_for_page_flip() into an async fn.
ogoffart
approved these changes
Jan 8, 2025
| @@ -10,15 +10,17 @@ use i_slint_core::platform::PlatformError; | |||
|
|
|||
| pub struct DumbBufferDisplay { | |||
| drm_output: DrmOutput, | |||
| front_buffer: RefCell<DumbBuffer>, | |||
| back_buffer: RefCell<DumbBuffer>, | |||
| front_buffer: RefCell<DumbBuffer>, // Currently displayed | |||
There was a problem hiding this comment.
(minor style nitpick: could be doc comments inside of trailing comments)
There was a problem hiding this comment.
Ok :) will fix tomorrow but merge this now so it’ll be in the nightly packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies code and (more importantly) avoids getting accidentally frame-locked into 30 FPS when rendering takes slightly longer than 16ms.
Fixes #6951