Include a third-party license attribution in the binary C++ packages #7302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate a top-level licenses/ folder and include it in the CPack archive.
|
(I'm not 100% sure this is a good location within the archive) |
|
Test run that has sample archives: https://github.com/slint-ui/slint/actions/runs/12673255510/job/35319212718 |
ogoffart
approved these changes
Jan 8, 2025
| @@ -56,7 +56,7 @@ jobs: | |||
| with: | |||
| crate: cargo-about | |||
| - name: Prepare licenses | |||
| run: bash -x ../../scripts/prepare_binary_package.sh ../.. | |||
| run: bash -x ../../scripts/prepare_binary_package.sh ${{ runner.workspace }}/cppbuild | |||
There was a problem hiding this comment.
It produced the files, but they weren’t included in the package. Now they’re placed in the bin dir and packaged via the cmake change. The only place where this worked is slint_tool_binary.yaml :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a top-level licenses/ folder and include it in the CPack archive.