Add support for triple buffered partial rendering with Skia #7440
+87
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Jan 23, 2025
internal/renderers/skia/lib.rs
Outdated
| @@ -120,6 +119,8 @@ pub struct SkiaRenderer { | |||
| pre_present_callback: RefCell<Option<Box<dyn FnMut()>>>, | |||
| partial_rendering_state: Option<PartialRenderingState>, | |||
| visualize_dirty_region: bool, | |||
| /// Tracking dirty regions indexed by buffer age - 1. More than 3 back buffers aren't supported, but also unlikely to happen. | |||
| back_buffer_dirty_regions_by_age_minus_1: RefCell<[DirtyRegion; 3]>, | |||
There was a problem hiding this comment.
There must exist a better name :-). Maybe dirty_region_history
There was a problem hiding this comment.
That is a better name - thanks :)
tronical
force-pushed
the
simon/partial-renderer-triple-buffer
branch
from
ba7ba9a to
39b27bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #7247