feat(index.js, RSVPModel.js, rsvp.js): add rsvp model and routes #16
Conversation
add rsvp model and routes to create and get an authenticated user's rsvp
There was a problem hiding this comment.
If you have any questions about the comments, feel free to ask!
In addition to the conditional required and field types of the model,
consider looking at the implementation of the frontend
https://github.com/slohacks/attendee-application/blob/master/src/containers/RSVP.jsx
I'll look more into this.
Another implementation is ignore conditional required fields
and just initiate them to null.
src/models/RSVPModel.js
Outdated
| min: 0, | ||
| max: 4, | ||
| required: function () { return this.attending } | ||
|
|
src/models/RSVPModel.js
Outdated
| min: 0, | ||
| max: 2, | ||
| required: function () { return this.attending && this.bus === 1 } | ||
|
|
There was a problem hiding this comment.
Remove additional blank line.
src/models/RSVPModel.js
Outdated
| required: function () { return this.attending } | ||
|
|
||
| }, | ||
| travelType: { |
There was a problem hiding this comment.
This tag should be transportation check out https://github.com/slohacks/attendee-application/blob/master/src/containers/data/rsvpData.json
| max: 2, | ||
| required: function () { return this.attending } | ||
| }, | ||
| bus: { |
| required: function () { return this.attending && this.travelType === 0 } | ||
| }, | ||
| socal: { | ||
| type: Number, |
There was a problem hiding this comment.
Currently, the frontend sends this as a string. thoughts on number vs string?
There was a problem hiding this comment.
Tommy and I think it is easier to store this data as a string as well, I am updating the Application model to reflect this.
| max: 2, | ||
| required: function () { return this.attending && this.bus === 0 } | ||
| }, | ||
| norcal: { |
| @@ -0,0 +1,57 @@ | |||
| const mongoose = require('mongoose') | |||
|
|
|||
| const RSVP = mongoose.model('RSVP', { | |||
There was a problem hiding this comment.
Think about how we should expire out RSVP, ex if user is accepted but RSVPS after 7 days how do we prevent them from creating a document
src/routers/rsvp.js
Outdated
| } | ||
| }) | ||
|
|
||
| router.get('/rsvp/', authMiddleware, async (req, res) => { |
There was a problem hiding this comment.
/rsvp/:id is more concise, Change it to that implementation. I remember talking about it doesnt make sense for us to pull a specific RSVP but just to be consistent with other routes/models, change the implementation to reflect that.
…s user admin rights Added email check in authMiddleware to give @slohacks.com users access to all rsvps
add rsvp model and routes to create and get an authenticated user's rsvp