Fix windows version #520
Open
Fix windows version #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celuchmarek
changed the title
celuchmarek
commented
Jan 23, 2025
| static { | ||
| assetsPath = Path.of(requireNonNull(AssetsEndpoint.class.getResource("index.html")).getPath()).getParent().resolve("assets"); |
There was a problem hiding this comment.
Toto padalo ešte pri spustení appky. Keďže je to ale na takomto "static" mieste, exception sa nedal nikde chytiť a len to zobrazilo "Failed to load JVM".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No, ukázalo sa, že tie pathy pri assetoch na windowse nebudú ani za svet fungovať. Pôvodné riešenie v main branchi má problém, že Path.of() nevie spracovať string s dvojbodkami, čo vo Windowse bude vždy (C://nieco...). Na to som našiel iné riešenie, ale to zase fungovalo iba v developmente. Nakoniec to vyriešime tak, že máme whitelist súborov a mimetype zistíme podľa koncovky.
Keď som si už rozbehol dev prostredie na windowse (a viem aj buildovať installer!!!), pridal som desktop shortcut a zmenil som "description" packagu na "name", pretože to je to, čo sa ukazuje v prehlidači, keď ide user spúšťať Autogram z browsera. Predtým sa to usera pýtalo, či chce spsustiť aplikáciu "Opensource EIDAS compliant ...". Teraz tam bude že "Autogram".