Added PubSub.waitFor #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smikhalevski
requested changes
May 6, 2024
src/main/PubSub.ts
Outdated
| * @param predicate A function that takes the message as a parameter and returns true if the message satisfies the condition, otherwise false. | ||
| * @returns A promise that resolves with the published message that satisfies the predicate. | ||
| */ | ||
| waitFor(predicate: (message: T) => boolean): Promise<T> { |
There was a problem hiding this comment.
Suggested change
| waitFor(predicate: (message: T) => boolean): Promise<T> { | |
| waitFor<R extends T>(predicate: (message: T) => message is R): Promise<R>; | |
| waitFor(predicate: (message: T) => boolean): Promise<T>; | |
| waitFor(predicate: (message: T) => boolean) { |
src/test/PubSub.test.ts
Outdated
Comment on lines
59
to
70
| const pubSub = new PubSub<number>(); | ||
|
|
||
| pubSub | ||
| .waitFor(message => message === 42) | ||
| .then(message => { | ||
| expect(message).toBe(42); | ||
| }); | ||
|
|
||
| pubSub.publish(10); | ||
| pubSub.publish(20); | ||
| pubSub.publish(42); | ||
| pubSub.publish(30); |
There was a problem hiding this comment.
Suggested change
| const pubSub = new PubSub<number>(); | |
| pubSub | |
| .waitFor(message => message === 42) | |
| .then(message => { | |
| expect(message).toBe(42); | |
| }); | |
| pubSub.publish(10); | |
| pubSub.publish(20); | |
| pubSub.publish(42); | |
| pubSub.publish(30); | |
| const pubSub = new PubSub<number>(); | |
| const promise = pubSub.waitFor(message => message === 42); | |
| pubSub.publish(10); | |
| pubSub.publish(20); | |
| pubSub.publish(42); | |
| pubSub.publish(30); | |
| await expect(promise).resolves.toBe(42); |
src/test/PubSub.test.ts
Outdated
| pubSub.publish(30); | ||
| }); | ||
|
|
||
| test('does not resolve if no message matches the predicate', () => { |
There was a problem hiding this comment.
This test is redundant. The scenario is covered in the preceding test.
smikhalevski
reviewed
May 6, 2024
src/main/PubSub.ts
Outdated
Comment on lines
43
to
69
| return new Promise(resolve => { | ||
| const unsubscribe = this.subscribe(message => { | ||
| if (predicate(message)) { | ||
| resolve(message); | ||
| unsubscribe(); | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| return new Promise(resolve => { | |
| const unsubscribe = this.subscribe(message => { | |
| if (predicate(message)) { | |
| resolve(message); | |
| unsubscribe(); | |
| } | |
| }); | |
| }); | |
| return new AbortablePromise((resolve, _reject, signal) => { | |
| const unsubscribe = this.subscribe(message => { | |
| if (predicate(message)) { | |
| resolve(message); | |
| unsubscribe(); | |
| } | |
| }); | |
| signal.addEventLisetner('abort', unsubscribe); | |
| }); |
smikhalevski
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.