-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added build workflow #9
Conversation
WalkthroughThe project has introduced a GitHub Actions workflow for automated building and pushing of container images to the GitHub Container Registry, triggered by version-tagged pushes. Additionally, the Helm chart packaging process has been refined with a new Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (15)
- chart/Chart.yaml
- chart/templates/basicauthenticator-crd.yaml
- chart/templates/deployment.yaml
- chart/templates/leader-election-rbac.yaml
- chart/templates/manager-rbac.yaml
- chart/templates/metrics-reader-rbac.yaml
- chart/templates/metrics-service.yaml
- chart/templates/mutating-webhook-configuration.yaml
- chart/templates/proxy-rbac.yaml
- chart/templates/selfsigned-issuer.yaml
- chart/templates/serviceaccount.yaml
- chart/templates/serving-cert.yaml
- chart/templates/validating-webhook-configuration.yaml
- chart/templates/webhook-service.yaml
- chart/values.yaml
Files selected for processing (3)
- .github/workflows/build.yaml (1 hunks)
- chart/.helmignore (1 hunks)
- chart/templates/_helpers.tpl (1 hunks)
Files skipped from review due to trivial changes (1)
- chart/.helmignore
Additional comments: 2
.github/workflows/build.yaml (1)
- 1-46: The GitHub Actions workflow is correctly set up to trigger on tag pushes matching 'v*', build the Docker container image, and push it to the GitHub Container Registry. It also includes steps to install operator-sdk and build and push a bundle, which aligns with the PR objectives. Ensure that the fixed version of operator-sdk (v1.31.0) is the intended version to use.
chart/templates/_helpers.tpl (1)
- 1-62: The changes to the Helm chart template helpers are consistent with the PR objectives and follow Kubernetes naming conventions. Ensure that existing deployments are checked for compatibility with these new naming conventions to avoid potential issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- config/manifests/bases/basicauthenticator.clusterserviceversion.yaml
Files selected for processing (1)
- bundle.Dockerfile (1 hunks)
Additional comments: 1
bundle.Dockerfile (1)
- 1-20: The Dockerfile hunk provided correctly sets up the Operator Bundle image using a scratch base image, includes appropriate labels for the Operator Framework, and copies the necessary bundle files into the image. Ensure that the Operator SDK version mentioned in the labels matches the version used in the GitHub Actions workflow if they are intended to be in sync.
Add workflow for the helm chart release. |
Summary by CodeRabbit
New Features
.helmignore
file to ensure cleaner and more efficient Helm chart packaging.Documentation
Chores