Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added build workflow #9

Merged
merged 3 commits into from
Dec 4, 2023
Merged

added build workflow #9

merged 3 commits into from
Dec 4, 2023

Conversation

sinamna
Copy link
Collaborator

@sinamna sinamna commented Dec 4, 2023

Summary by CodeRabbit

  • New Features

    • Implemented a GitHub Actions workflow for automated building and pushing of container images upon new version tags.
    • Introduced a .helmignore file to ensure cleaner and more efficient Helm chart packaging.
  • Documentation

    • Updated Helm chart templates to improve naming conventions and label generation for Kubernetes resources.
  • Chores

    • Streamlined CI/CD processes with the addition of operator-sdk installation and bundle push in the workflow.

Copy link

coderabbitai bot commented Dec 4, 2023

Walkthrough

The project has introduced a GitHub Actions workflow for automated building and pushing of container images to the GitHub Container Registry, triggered by version-tagged pushes. Additionally, the Helm chart packaging process has been refined with a new .helmignore file to exclude unnecessary files, and updates to the _helpers.tpl to enhance naming and labeling consistency for Kubernetes resources.

Changes

File Path Change Summary
.github/workflows/build.yaml Added a GitHub Actions workflow for building and pushing container images on version-tagged pushes.
chart/.helmignore Created a .helmignore file to specify patterns of files to exclude from Helm chart packaging.
chart/templates/_helpers.tpl Updated template logic for improved naming and labeling of Kubernetes resources.
bundle.Dockerfile Added core bundle labels for an operator framework, labels for testing, and file copying based on labels.

🐇✨
To the registry, our images sail,
With tags on the wind and a Helm that won't fail.
A rabbit's touch to the code we weave,
Naming our pods with the tricks up our sleeve.
🚀🌟


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between aa09787 and 7472f3b.
Files ignored due to filter (15)
  • chart/Chart.yaml
  • chart/templates/basicauthenticator-crd.yaml
  • chart/templates/deployment.yaml
  • chart/templates/leader-election-rbac.yaml
  • chart/templates/manager-rbac.yaml
  • chart/templates/metrics-reader-rbac.yaml
  • chart/templates/metrics-service.yaml
  • chart/templates/mutating-webhook-configuration.yaml
  • chart/templates/proxy-rbac.yaml
  • chart/templates/selfsigned-issuer.yaml
  • chart/templates/serviceaccount.yaml
  • chart/templates/serving-cert.yaml
  • chart/templates/validating-webhook-configuration.yaml
  • chart/templates/webhook-service.yaml
  • chart/values.yaml
Files selected for processing (3)
  • .github/workflows/build.yaml (1 hunks)
  • chart/.helmignore (1 hunks)
  • chart/templates/_helpers.tpl (1 hunks)
Files skipped from review due to trivial changes (1)
  • chart/.helmignore
Additional comments: 2
.github/workflows/build.yaml (1)
  • 1-46: The GitHub Actions workflow is correctly set up to trigger on tag pushes matching 'v*', build the Docker container image, and push it to the GitHub Container Registry. It also includes steps to install operator-sdk and build and push a bundle, which aligns with the PR objectives. Ensure that the fixed version of operator-sdk (v1.31.0) is the intended version to use.
chart/templates/_helpers.tpl (1)
  • 1-62: The changes to the Helm chart template helpers are consistent with the PR objectives and follow Kubernetes naming conventions. Ensure that existing deployments are checked for compatibility with these new naming conventions to avoid potential issues.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7472f3b and e0357f7.
Files ignored due to filter (1)
  • config/manifests/bases/basicauthenticator.clusterserviceversion.yaml
Files selected for processing (1)
  • bundle.Dockerfile (1 hunks)
Additional comments: 1
bundle.Dockerfile (1)
  • 1-20: The Dockerfile hunk provided correctly sets up the Operator Bundle image using a scratch base image, includes appropriate labels for the Operator Framework, and copies the necessary bundle files into the image. Ensure that the Operator SDK version mentioned in the labels matches the version used in the GitHub Actions workflow if they are intended to be in sync.

@hoptical hoptical self-requested a review December 4, 2023 10:07
@hoptical
Copy link
Collaborator

hoptical commented Dec 4, 2023

Add workflow for the helm chart release.

@sinamna sinamna merged commit 68356b5 into main Dec 4, 2023
1 check passed
@sinamna sinamna deleted the add-build-workflow branch December 11, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants