Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walking for anonymous structs #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mitchellkelly
Copy link

The package currently ignores embedded struct fields so patches wont get created for them. This PR adds the ability to walk embedded structs

@snorwin
Copy link
Owner

snorwin commented Nov 20, 2024

Hey @mitchellkelly, thanks for your contribution—it looks like an interesting use case! If you don’t mind, could you also extend the tests to cover it?

(In the meantime I will check the linter issues, I might have to upgrade the test framework)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11895335585

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 91.494%

Totals Coverage Status
Change from base Build 10663367814: 0.3%
Covered Lines: 398
Relevant Lines: 435

💛 - Coveralls

@mitchellkelly
Copy link
Author

@snorwin I added some tests! Let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants