fix: sonar issues

soat-tech-challenge · Jan 26, 2024 · 929355d · 929355d
1 parent fd87dd2
commit 929355d
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 116 deletions.
diff --git a/...om/grupo63/serviceproduction/api/controller/status/dto/AdvanceOrderStatusResponseDTO.java b/...om/grupo63/serviceproduction/api/controller/status/dto/AdvanceOrderStatusResponseDTO.java
@@ -7,8 +7,6 @@
 import lombok.Setter;
 
 @Getter
-@Setter
-@NoArgsConstructor
 @AllArgsConstructor
 public class AdvanceOrderStatusResponseDTO {
 

diff --git a/src/main/java/br/com/grupo63/serviceproduction/config/JwtFilter.java b/src/main/java/br/com/grupo63/serviceproduction/config/JwtFilter.java
diff --git a/src/main/java/br/com/grupo63/serviceproduction/config/JwtFilterConfig.java b/src/main/java/br/com/grupo63/serviceproduction/config/JwtFilterConfig.java
diff --git a/src/main/java/br/com/grupo63/serviceproduction/config/JwtService.java b/src/main/java/br/com/grupo63/serviceproduction/config/JwtService.java
diff --git a/src/main/java/br/com/grupo63/serviceproduction/entity/status/Status.java b/src/main/java/br/com/grupo63/serviceproduction/entity/status/Status.java
@@ -12,7 +12,6 @@
 import static java.util.Map.entry;
 
 @AllArgsConstructor
-@NoArgsConstructor
 @Getter
 @Setter
 public class Status {

diff --git a/src/main/java/br/com/grupo63/serviceproduction/gateway/status/IStatusGateway.java b/src/main/java/br/com/grupo63/serviceproduction/gateway/status/IStatusGateway.java
@@ -1,12 +1,14 @@
 package br.com.grupo63.serviceproduction.gateway.status;
 
 import br.com.grupo63.serviceproduction.entity.status.Status;
-import br.com.grupo63.techchallenge.common.gateway.IPersistenceEntityGateway;
 
 import java.util.List;
 import java.util.Optional;
 
-public interface IStatusGateway extends IPersistenceEntityGateway<Status> {
+public interface IStatusGateway {
+
+    Status saveAndFlush(Status entity);
+
     List<Status> findByStatusNotFinishedAndDeletedOrderByCreationDate();
 
     Optional<Status> findByDeletedFalseAndOrder(int order);

diff --git a/src/main/java/br/com/grupo63/serviceproduction/gateway/status/StatusJpaAdapter.java b/src/main/java/br/com/grupo63/serviceproduction/gateway/status/StatusJpaAdapter.java
@@ -38,14 +38,6 @@ public Optional<Status> findByDeletedFalseAndOrder(int order) {
                 .map(StatusPersistenceEntity::toModel);
     }
 
-    @Override
-    public List<Status> findByDeletedFalse() {
-        return repository.findByDeletedFalse()
-                .stream()
-                .map(StatusPersistenceEntity::toModel)
-                .collect(Collectors.toList());
-    }
-
     @Override
     public Status saveAndFlush(Status status) {
         StatusPersistenceEntity entity = new StatusPersistenceEntity(status);
@@ -54,10 +46,4 @@ public Status saveAndFlush(Status status) {
 
         return entity.toModel();
     }
-
-    @Override
-    public Optional<Status> findByIdAndDeletedFalse(Long id) {
-        return repository.findByIdAndDeletedFalse(id)
-                .map(StatusPersistenceEntity::toModel);
-    }
 }
diff --git a/.../java/br/com/grupo63/serviceproduction/gateway/status/entity/StatusPersistenceEntity.java b/.../java/br/com/grupo63/serviceproduction/gateway/status/entity/StatusPersistenceEntity.java
@@ -11,9 +11,7 @@
 import java.time.LocalDateTime;
 
 @AllArgsConstructor
-@NoArgsConstructor
 @Getter
-@Setter
 
 @DynamoDBTable(tableName = "status")
 public class StatusPersistenceEntity {