Skip to content

Commit

Permalink
Fix submodule initialization for CIMpp in Dockerfiles. (#331)
Browse files Browse the repository at this point in the history
This PR fixes the building process of CIMpp in the Docker files. Since
we are now checking out a specific commit of this library, we need to
make sure that the git submodules are updated after the checkout.
  • Loading branch information
m-mirz authored Jan 24, 2025
2 parents c070bc7 + 1b946a4 commit 61dd436
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion packaging/Docker/Dockerfile.dev
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,10 @@ RUN pip3 install -r requirements.txt

# Install CIMpp from source
RUN cd /tmp && \
git clone --recurse-submodules https://github.com/cim-iec/libcimpp.git && \
git clone https://github.com/sogno-platform/libcimpp.git && \
mkdir -p libcimpp/build && cd libcimpp/build && \
git checkout ${CIMPP_COMMIT} && \
git submodule update --init && \
cmake ${CMAKE_OPTS} ..\
-DBUILD_SHARED_LIBS=ON \
-DCMAKE_INSTALL_LIBDIR=/usr/local/lib64 \
Expand Down
3 changes: 2 additions & 1 deletion packaging/Docker/Dockerfile.dev-debian
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ RUN pip3 install -r requirements.txt

## Install CIMpp from source
RUN cd /tmp && \
git clone --recurse-submodules https://github.com/cim-iec/libcimpp.git && \
git clone https://github.com/sogno-platform/libcimpp.git && \
mkdir -p libcimpp/build && cd libcimpp/build && \
git checkout ${CIMPP_COMMIT} && \
git submodule update --init && \
cmake ${CMAKE_OPTS} .. \
-DBUILD_SHARED_LIBS=ON \
-DCMAKE_INSTALL_LIBDIR=/usr/local/lib \
Expand Down
3 changes: 2 additions & 1 deletion packaging/Docker/Dockerfile.dev-rocky
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,10 @@ RUN pip3 install gprof2dot

# Install CIMpp from source
RUN cd /tmp && \
git clone --recurse-submodules https://github.com/cim-iec/libcimpp.git && \
git clone https://github.com/sogno-platform/libcimpp.git && \
mkdir -p libcimpp/build && cd libcimpp/build && \
git checkout ${CIMPP_COMMIT} && \
git submodule update --init && \
cmake ${CMAKE_OPTS} ..\
-DCMAKE_INSTALL_LIBDIR=/usr/local/lib64 \
-DUSE_CIM_VERSION=${CIM_VERSION} \
Expand Down
3 changes: 2 additions & 1 deletion packaging/Docker/Dockerfile.manylinux
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ RUN pip3 install -r requirements-manylinux.txt

# Install CIMpp from source
RUN cd /tmp && \
git clone --recurse-submodules https://github.com/cim-iec/libcimpp.git && \
git clone https://github.com/sogno-platform/libcimpp.git && \
mkdir -p libcimpp/build && cd libcimpp/build && \
git checkout ${CIMPP_COMMIT} && \
git submodule update --init && \
cmake ${CMAKE_OPTS} .. \
-DCMAKE_INSTALL_LIBDIR=/usr/local/lib64 \
-DUSE_CIM_VERSION=${CIM_VERSION} \
Expand Down

0 comments on commit 61dd436

Please sign in to comment.