Alternative fix for COMException MILERR_WIN32ERROR and correctly use …

…refresh interval when the app starts up.
soleon · Jan 10, 2025 · 3ec36bf · 3ec36bf
1 parent 3d6444c
commit 3ec36bf
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 15 deletions.
diff --git a/App/Extensions/NotifyIconExtensions.cs b/App/Extensions/NotifyIconExtensions.cs
@@ -40,19 +40,23 @@ internal static void SetIcon(this NotifyIcon notifyIcon, FrameworkElement textBl
         // Render the element with the correct DPI scale.
         var dpiScale = VisualTreeHelper.GetDpi(textBlock);
 
-        // There's a chance that some native exceptions may be thrown when rendering and setting the icon's image.
-        // Catch any exception here and retry a few times then fail silently.
-        DelegateExtensions.RetryOnException<Exception>(() =>
-        {
-            var renderTargetBitmap = new RenderTargetBitmap(
-                (int)Math.Round(DefaultNotifyIconSize * dpiScale.DpiScaleX, MidpointRounding.AwayFromZero),
-                (int)Math.Round(DefaultNotifyIconSize * dpiScale.DpiScaleY, MidpointRounding.AwayFromZero),
-                dpiScale.PixelsPerInchX,
-                dpiScale.PixelsPerInchY,
-                PixelFormats.Default);
-            renderTargetBitmap.Render(textBlock);
-            notifyIcon.Icon = renderTargetBitmap;
-            App.SetTrayIconUpdateError(null);
-        }, App.SetTrayIconUpdateError);
+        // There's a known issue that keep creating RenderTargetBitmap in a WPF app, the COMException: MILERR_WIN32ERROR
+        // may happen.
+        // This is reported as https://github.com/dotnet/wpf/issues/3067.
+        // Manually forcing a GC seems to help.
+        var renderTargetBitmap =
+            new RenderTargetBitmap(
+            (int)Math.Round(DefaultNotifyIconSize * dpiScale.DpiScaleX, MidpointRounding.AwayFromZero),
+            (int)Math.Round(DefaultNotifyIconSize * dpiScale.DpiScaleY, MidpointRounding.AwayFromZero),
+            dpiScale.PixelsPerInchX,
+            dpiScale.PixelsPerInchY,
+            PixelFormats.Default);
+        renderTargetBitmap.Render(textBlock);
+
+        // Force GC after each RenderTargetBitmap creation to avoid running into COMException: MILERR_WIN32ERROR.
+        GC.Collect();
+        GC.WaitForPendingFinalizers();
+
+        notifyIcon.Icon = renderTargetBitmap;
     }
 }
diff --git a/App/NotifyIconWindow.xaml.cs b/App/NotifyIconWindow.xaml.cs
@@ -42,7 +42,7 @@ public NotifyIconWindow()
         InitializeComponent();
 
         // Setup timer to update the tray icon.
-        _refreshTimer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(1) };
+        _refreshTimer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(Default.RefreshSeconds) };
         _refreshTimer.Tick += (_, _) => _batteryStatusUpdateSubject.OnNext(false);
     }