Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimelockProposal Arbitrum L1 example #72

Merged
merged 8 commits into from
May 15, 2024
Merged

Conversation

anajuliabit
Copy link
Member

LFG

@anajuliabit anajuliabit marked this pull request as ready for review May 14, 2024 23:54
@anajuliabit anajuliabit self-assigned this May 14, 2024
@ElliotFriedman
Copy link
Contributor

Let's go!

ElliotFriedman
ElliotFriedman previously approved these changes May 15, 2024
Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}
}

// Mock arbitrum outbox to return L2 timelock on l2ToL2Sender call
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Mock arbitrum outbox to return L2 timelock on l2ToL2Sender call
// Mock arbitrum outbox to return L2 timelock on l2ToL1Sender call

prateek105
prateek105 previously approved these changes May 15, 2024
Copy link
Collaborator

@prateek105 prateek105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@anajuliabit anajuliabit dismissed stale reviews from prateek105 and ElliotFriedman via 16cf4de May 15, 2024 12:19
@anajuliabit anajuliabit merged commit 81d8db9 into main May 15, 2024
4 checks passed
@anajuliabit anajuliabit deleted the timelock_arbitrum_l1_example branch May 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants