Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addresses.sol unit tests #9

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Addresses.sol unit tests #9

merged 4 commits into from
Dec 20, 2023

Conversation

anajuliabit
Copy link
Member

@anajuliabit anajuliabit commented Dec 19, 2023 •
edited
Loading

remediate #1

  • test_addAddress
  • test_addAddressChainId
  • test_addAddressDifferentChain
  • test_getAddress
  • test_getAddressChainId
  • test_getRecordingAddresses
  • test_resetRecordingAddresses
  • test_reverGetAddressNotSet
  • test_reverGetAddressNotSetOnChain
  • test_revertAddAddressAlreadySet
  • test_revertAddAddressChainAlreadySet
  • test_revertGetAddressChainZero

@anajuliabit anajuliabit changed the title getAddress tests Addresses.sol unit tests Dec 19, 2023
@anajuliabit anajuliabit marked this pull request as ready for review December 19, 2023 13:24
@anajuliabit anajuliabit self-assigned this Dec 19, 2023
ElliotFriedman
ElliotFriedman approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@ElliotFriedman ElliotFriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElliotFriedman ElliotFriedman merged commit 302d9da into main Dec 20, 2023
3 checks passed
@ElliotFriedman ElliotFriedman deleted the addresses_unit_test branch December 20, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElliotFriedman ElliotFriedman ElliotFriedman approved these changes

Assignees

@anajuliabit anajuliabit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anajuliabit @ElliotFriedman