-
Notifications
You must be signed in to change notification settings - Fork 746
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Test Gap] A VLAN interface should stay up when all of its member por…
…ts are operationally down (#15244) Fixes #14790 When all member ports of a VLAN are down, the VLAN interface should still remain operationally up. The added test file (test_vlan_ports_down.py) performs the following steps: Setup: Brings down all member ports of a VLAN interface. Asserts that the VLAN interface is operationally Up. Asserts that the VLAN interface's IPv4 and IPv6 subnets are advertised to the T1 neighbors. Asserts that IPv4 decapsulation feature works for the VLAN interface. Tear-down: Starts up all member ports of the VLAN interface. What is the motivation for this PR? When all member ports of a VLAN are down, the VLAN interface should still remain operationally up. How did you do it? We select a VLAN and then bring all of its member ports down. Then we assert all 3 conditions mentioned in the summary. How did you verify/test it? Ran the test on a virtual T0 switch (with Broadcom ASIC).
- Loading branch information
1 parent
976fc8c
commit de91c65
Showing
6 changed files
with
241 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # show_ipv6_interfaces | ||
|
|
||
| - [Overview](#overview) | ||
| - [Examples](#examples) | ||
| - [Arguments](#arguments) | ||
| - [Expected Output](#expected-output) | ||
|
|
||
| ## Overview | ||
| Retrieve information about IPv6 interfaces and parse the result into a dict. | ||
|
|
||
| ## Examples | ||
| ```python | ||
| def test_fun(duthosts, rand_one_dut_hostname): | ||
| duthost = duthosts[rand_one_dut_hostname] | ||
|
|
||
| ipv6_ifs = duthost.show_ipv6_interfaces() | ||
| ``` | ||
|
|
||
| ## Arguments | ||
| This function takes no arguments. | ||
|
|
||
| ## Expected Output | ||
| Returns a dictionary containing information about the DUT's IPv6 interfaces. | ||
| Note: The result does NOT contain link-local IPv6 addresses. | ||
|
|
||
| Example output: | ||
|
|
||
| ```json | ||
| { | ||
| "Ethernet16": { | ||
| "master": "Bridge", | ||
| "ipv6 address/mask": "fe80::2048:23ff:fe27:33d8%Ethernet16/64", | ||
| "admin": "up", | ||
| "oper": "up", | ||
| "bgp neighbor": "N/A", | ||
| "neighbor ip": "N/A" | ||
| }, | ||
| "PortChannel101": { | ||
| "master": "", | ||
| "ipv6 address/mask": "fc00::71/126", | ||
| "admin": "up", | ||
| "oper": "up", | ||
| "bgp neighbor": "ARISTA01T1", | ||
| "neighbor ip": "fc00::72" | ||
| }, | ||
| "eth5": { | ||
| "master": "", | ||
| "ipv6 address/mask": "fe80::5054:ff:fee6:bea6%eth5/64", | ||
| "admin": "up", | ||
| "oper": "up", | ||
| "bgp neighbor": "N/A", | ||
| "neighbor ip": "N/A" | ||
| } | ||
| } | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import pytest | ||
| import logging | ||
| import ptf.testutils as testutils | ||
| import ptf.mask as mask | ||
| import time | ||
|
|
||
| from netaddr import IPNetwork, NOHOST | ||
| from tests.common.helpers.assertions import pytest_assert | ||
| from scapy.all import IP, Ether | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('t0') | ||
| ] | ||
|
|
||
|
|
||
| @pytest.fixture(scope='module') | ||
| def vlan_ports_setup(duthosts, rand_one_dut_hostname): | ||
| """ | ||
| Setup: Brings down all member ports of a VLAN. | ||
| Teardown: Restores the admin state of all member ports of the VLAN selected in the Setup phase. | ||
| """ | ||
| duthost = duthosts[rand_one_dut_hostname] | ||
| vlan_brief = duthost.get_vlan_brief() | ||
| if not vlan_brief: | ||
| pytest.skip("The testbed does not have any VLANs.") | ||
| # Selecting the first VLAN in 'vlan_brief' | ||
| vlan_name = next(iter(vlan_brief)) | ||
| vlan_members = vlan_brief[vlan_name]["members"] | ||
| ifs_status = duthost.get_interfaces_status() | ||
| vlan_up_members = [port for port in vlan_members if ifs_status[port]["admin"] == "up"] | ||
| logger.info(f"Bringing down all member ports of {vlan_name}...") | ||
| for vlan_up_port in vlan_up_members: | ||
| duthost.shell(f"sudo config interface shutdown {vlan_up_port}") | ||
| time.sleep(5) # Sleep for 5 seconds to ensure T1 switches update their routing table | ||
| yield vlan_name | ||
| logger.info(f"Restoring the previous admin state of all member ports of {vlan_name}...") | ||
| for vlan_port in vlan_up_members: | ||
| duthost.shell(f"sudo config interface startup {vlan_port}") | ||
|
|
||
|
|
||
| def test_vlan_ports_down(vlan_ports_setup, duthosts, rand_one_dut_hostname, nbrhosts, tbinfo, ptfadapter): | ||
| """ | ||
| Asserts the following conditions when all member ports of a VLAN interface are down: | ||
| 1. The VLAN interface's oper status remains Up. | ||
| 2. The VLAN's subnet IP is advertised to the T1 neighbors. | ||
| 3. The IP decapsulation feature works for packets that are sent to the VLAN interfaces's IP address. | ||
| """ | ||
| duthost = duthosts[rand_one_dut_hostname] | ||
| vlan_name = vlan_ports_setup | ||
| ip_interfaces = duthost.show_ip_interface()["ansible_facts"]["ip_interfaces"] | ||
| vlan_info = ip_interfaces[vlan_name] | ||
| logger.info(f"Checking if {vlan_name} is oper UP...") | ||
| # check if the VLAN interface is operationally Up (IPv4) | ||
| pytest_assert(vlan_info["oper_state"] == "up", f"{vlan_name} is operationally down.") | ||
|
|
||
| ipv6_interfaces = duthost.show_ipv6_interfaces() | ||
| vlan_info_ipv6 = ipv6_interfaces[vlan_name] | ||
| # check if the VLAN interface is operationally Up (IPv6) | ||
| pytest_assert(vlan_info_ipv6["oper"] == "up", f"{vlan_name} is operationally down.") | ||
|
|
||
| logger.info("Checking BGP routes on T1 neighbors...") | ||
| vlan_subnet = str(IPNetwork(f"{vlan_info['ipv4']}/{vlan_info['prefix_len']}", flags=NOHOST)) | ||
| vlan_subnet_ipv6 = str(IPNetwork(vlan_info_ipv6["ipv6 address/mask"], flags=NOHOST)) | ||
| nbrcount = 0 | ||
| for nbrname, nbrhost in nbrhosts.items(): | ||
| nbrhost = nbrhost["host"] | ||
| # check IPv4 routes on nbrhost | ||
| logger.info(f"Checking IPv4 routes on {nbrname}...") | ||
| try: | ||
| vlan_route = nbrhost.get_route(vlan_subnet)["vrfs"]["default"] | ||
| except Exception: | ||
| # nbrhost might be unreachable. Skip it. | ||
| logger.info(f"{nbrname} might be unreachable.") | ||
| continue | ||
| pytest_assert(vlan_route["bgpRouteEntries"], | ||
| f"{vlan_name}'s IPv4 subnet is not advertised to the T1 neighbor {nbrname}.") | ||
| # check IPv6 routes on nbrhost | ||
| logger.info(f"Checking IPv6 routes on {nbrname}...") | ||
| try: | ||
| vlan_route_ipv6 = nbrhost.get_route(vlan_subnet_ipv6)["vrfs"]["default"] | ||
| except Exception: | ||
| # nbrhost might be unreachable. Skip it. | ||
| logger.info(f"{nbrname} might be unreachable.") | ||
| continue | ||
| pytest_assert(vlan_route_ipv6["bgpRouteEntries"], | ||
| f"{vlan_name}'s IPv6 subnet is not advertised to the T1 neighbor {nbrname}.") | ||
| nbrcount += 1 | ||
| if nbrcount == 0: | ||
| pytest.skip("Could not get routing info from any T1 neighbors.") | ||
| if duthost.facts["asic_type"].lower() == "vs": | ||
| logger.info("Skipping IP-in-IP decapsulation test for the 'vs' ASIC type.") | ||
| return | ||
| logger.info("Starting the IP-in-IP decapsulation test...") | ||
| mg_facts = duthost.get_extended_minigraph_facts(tbinfo) | ||
| # Use the first Ethernet port associated with the first portchannel to send test packets to the DUT | ||
| portchannel_info = next(iter(mg_facts["minigraph_portchannels"].values())) | ||
| ptf_src_port = portchannel_info["members"][0] | ||
| ptf_src_port_index = mg_facts["minigraph_ptf_indices"][ptf_src_port] | ||
| ptf_dst_port_indices = list(mg_facts["minigraph_ptf_indices"].values()) | ||
| # Test IPv4 in IPv4 decapsulation. | ||
| # Outer IP packet: | ||
| # src: 1.1.1.1 | ||
| # dst: VLAN interface's IPv4 address | ||
| # Inner IP packet: | ||
| # src: 2.2.2.2 | ||
| # dst: 3.3.3.3 | ||
| # Expectation: The T0 switch (DUT) decapsulates the outer IP packet and sends | ||
| # the inner IP packet to the default gateway (one of the connected T1 switches). | ||
| inner_pkt = testutils.simple_udp_packet(ip_src="2.2.2.2", | ||
| ip_dst="3.3.3.3") | ||
| outer_pkt = testutils.simple_ipv4ip_packet(eth_src=ptfadapter.dataplane.get_mac(0, ptf_src_port_index), | ||
| eth_dst=duthost.facts["router_mac"], | ||
| ip_src="1.1.1.1", | ||
| ip_dst=vlan_info["ipv4"], | ||
| inner_frame=inner_pkt["IP"]) | ||
| exp_pkt = inner_pkt.copy() | ||
| exp_pkt = mask.Mask(exp_pkt) | ||
| exp_pkt.set_do_not_care_packet(Ether, "src") | ||
| exp_pkt.set_do_not_care_packet(Ether, "dst") | ||
| exp_pkt.set_do_not_care_packet(IP, "ttl") | ||
| exp_pkt.set_do_not_care_packet(IP, "chksum") | ||
| exp_pkt.set_do_not_care_packet(IP, "tos") | ||
| logger.info("Sending the IP-in-IP packet...") | ||
| testutils.send(ptfadapter, ptf_src_port_index, outer_pkt) | ||
| logger.info("IP-in-IP packet sent.") | ||
| testutils.verify_packet_any_port(ptfadapter, exp_pkt, ports=ptf_dst_port_indices) |