-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test fdb mac move #12459
Merged
bpar9
merged 21 commits into
sonic-net:master
from
anshuldubela:anshuldubela/test_fdb_mac_move
Nov 27, 2024
Merged
test fdb mac move #12459
bpar9
merged 21 commits into
sonic-net:master
from
anshuldubela:anshuldubela/test_fdb_mac_move
Nov 27, 2024
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anshul Dubela <andubela@cisco.com>
Signed-off-by: Anshul Dubela <andubela@cisco.com>
"tests/dualtor/test_standby_tor_upstream_mux_toggle.py:89:121: E501 line too long (123 > 120 characters)"
"tests/dualtor/test_standby_tor_upstream_mux_toggle.py:89:121: E501 line too long (123 > 120 characters)"
# For Cisco-8000 devices, hardware counters are statistical-based with +/- 1 entry tolerance. # Hence, the available counters may not increase as per initial value for multiple facts collected.
# For Cisco-8000 devices, hardware counters are statistical-based with +/- 1 entry tolerance. # Hence, the available counter may not increase as per initial value.
Removed the extra line.
Fix below pre-commit error: tests/dualtor/test_standby_tor_upstream_mux_toggle.py:95:39: E225 missing whitespace around operator
Fixed Below pre-commit issue: trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/common/utilities.py
Signed-off-by: Anshul Dubela <andubela@cisco.com>
Rev 8454 Unmatched CRM facts rev
Signed-off-by: Anshul Dubela <andubela@cisco.com>
@yutongzhang-microsoft Please review. |
yutongzhang-microsoft
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bpar9
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
name="test_fdb_mac_move"
failure message="Failed: FDB Table Cleanup failed"
Summary:
Fixes # (issue)
The Test tests/fdb/test_fdb_mac_move.py performs below operations.
Flush dataplane
While verification we found that the Flush dataplane was not flushing all the data.
ptfadapter.dataplane.flush()
So, we have added extra 10Sec time to it.
time.sleep(10)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation