Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fdb mac move #12459

Merged
merged 21 commits into from
Nov 27, 2024
Merged

Conversation

anshuldubela
Copy link
Contributor

@anshuldubela anshuldubela commented Apr 15, 2024

Description of PR

name="test_fdb_mac_move"
failure message="Failed: FDB Table Cleanup failed"

Summary:
Fixes # (issue)
The Test tests/fdb/test_fdb_mac_move.py performs below operations.

  • Perform FDB clean up before each test
  • reinitialize data plane due to changes on PTF interfaces
  • Take interfaces that are in ptf topology
  • If DUT has more than one VLANs, use the first vlan
  • Flush dataplane
  • Wait for 10 seconds before starting next loop

Flush dataplane
While verification we found that the Flush dataplane was not flushing all the data.
ptfadapter.dataplane.flush()

So, we have added extra 10Sec time to it.
time.sleep(10)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

anshuldubela and others added 21 commits August 1, 2023 14:29
Signed-off-by: Anshul Dubela <andubela@cisco.com>
Signed-off-by: Anshul Dubela <andubela@cisco.com>
"tests/dualtor/test_standby_tor_upstream_mux_toggle.py:89:121: E501 line too long (123 > 120 characters)"
"tests/dualtor/test_standby_tor_upstream_mux_toggle.py:89:121: E501 line too long (123 > 120 characters)"
    # For Cisco-8000 devices, hardware counters are statistical-based with +/- 1 entry tolerance.
    # Hence, the available counters may not increase as per initial value for multiple facts collected.
        # For Cisco-8000 devices, hardware counters are statistical-based with +/- 1 entry tolerance.
        # Hence, the available counter may not increase as per initial value.
Removed the extra line.
Fix below pre-commit error:
tests/dualtor/test_standby_tor_upstream_mux_toggle.py:95:39: E225 missing whitespace around operator
Fixed Below pre-commit issue:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/common/utilities.py
Signed-off-by: Anshul Dubela <andubela@cisco.com>
Signed-off-by: Anshul Dubela <andubela@cisco.com>
@anshuldubela anshuldubela changed the title Anshuldubela/test fdb mac move test fdb mac move Apr 15, 2024
@anshuldubela
Copy link
Contributor Author

@yutongzhang-microsoft Please review.

Copy link
Contributor

@yutongzhang-microsoft yutongzhang-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bpar9 bpar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bpar9 bpar9 merged commit 620b5ce into sonic-net:master Nov 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants