[action] [PR:10838] [T2] Add case to test lossy fair-voq #14447

mssonicbld · 2024-09-06T02:13:20Z

Description of PR

1, Add a new case to test lossy fair-voq.
2, Add lossy_queue_voq_2 and lossy_queue_voq_3 to qos_param_generator.py.
Default-voq and fair-voq will pass lossy_queue_voq_2, fair-voq and split-voq will pass lossy_queue_voq_3.

Summary:
Fixes # (issue)

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

201911
202012
202205
202305

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Case testQosSaiLossyQueueVoqMultiSrc

vanguard(Q200 longlink, default voq) skipped:

-------------------------------------------------- generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoqMultiSrc.xml --------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------
01:57:15 __init__.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
===================================================================================== short test summary info =====================================================================================
SKIPPED [1] /data/tests/qos/qos_sai_base.py:2125: This test is skipped for egress asic HBM enabled systems.
=================================================================================== 1 skipped in 355.75 seconds ===================================================================================

lancer(Q200 shortlink, fair voq) passed:

============================================================================================= PASSES ==============================================================================================
_____________________________________________________________________ TestQosSai.testQosSaiLossyQueueVoqMultiSrc[single_asic] _____________________________________________________________________
-------------------------------------------------- generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoqMultiSrc.xml --------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------
00:53:24 __init__.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
===================================================================================== short test summary info =====================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoqMultiSrc[single_asic]
=================================================================================== 1 passed in 389.64 seconds ====================================================================================

Case testQosSaiLossyQueueVoq

Vanguard skipped lossy_queue_voq_1, passed lossy_queue_voq_2.

============================================================================================= PASSES ==============================================================================================
________________________________________________________________ TestQosSai.testQosSaiLossyQueueVoq[single_asic-lossy_queue_voq_2] ________________________________________________________________
------------------------------------------------------ generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoq.xml ------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------
01:17:13 __init__.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
===================================================================================== short test summary info =====================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoq[single_asic-lossy_queue_voq_2]
SKIPPED [1] /data/tests/qos/test_qos_sai.py:1135: LossyQueueVoq: This test is skipped since cisco-8000 T2 doesn't support split-voq.
============================================================================== 1 passed, 1 skipped in 608.24 seconds ==============================================================================

Lancer skipped lossy_queue_voq_1, passed lossy_queue_voq_2.

============================================================================================= PASSES ==============================================================================================
________________________________________________________________ TestQosSai.testQosSaiLossyQueueVoq[single_asic-lossy_queue_voq_2] ________________________________________________________________
------------------------------------------------------ generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoq.xml ------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
------------------------------------------------------------------------------------- live log sessionfinish --------------------------------------------------------------------------------------
01:32:15 __init__.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
===================================================================================== short test summary info =====================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiLossyQueueVoq[single_asic-lossy_queue_voq_2]
SKIPPED [1] /data/tests/qos/test_qos_sai.py:1135: LossyQueueVoq: This test is skipped since cisco-8000 T2 doesn't support split-voq.
============================================================================== 1 passed, 1 skipped in 615.21 seconds ==============================================================================

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

1, Add a new case to test lossy fair-voq. 2, Add lossy_queue_voq_2 and lossy_queue_voq_3 to qos_param_generator.py. Default-voq and fair-voq will pass lossy_queue_voq_2, fair-voq and split-voq will pass lossy_queue_voq_3.

mssonicbld · 2024-09-06T02:13:24Z

Original PR: #10838

mssonicbld · 2024-09-06T02:14:16Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271 flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

kevinskwang · 2024-09-06T08:52:09Z

@zhixzhu could you check the error?

hook id: flake8
exit code: 1

tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

mssonicbld · 2024-09-07T01:51:55Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-09-07T01:52:06Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-09-07T01:52:24Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271 flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-09-09T01:58:36Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-09-09T01:58:47Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-09-09T01:59:39Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271 flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

zhixzhu · 2024-09-09T16:43:53Z

mssonicbld#1
@XuChen-MSFT This PR is to fix pre-commit failure, I don't have write access of mssonicbld:cherry/202311/10838

mssonicbld · 2024-09-10T01:55:33Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-09-10T01:55:43Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-09-10T01:56:37Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271 flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

XuChen-MSFT

cherry-pick PR #10838 to 202311.
it's dependency of PR #13384

XuChen-MSFT · 2024-09-12T03:02:54Z

tests/qos/qos_sai_base.py

@@ -2267,6 +2267,16 @@ def skip_pacific_dst_asic(self, dutConfig):
        yield
        return

+    @pytest.fixture(scope="function", autouse=False)
+    def skip_longlink(self, dutQosConfig):


@zhixzhu
pre-commit check failed, as below:

Pre-commit check results:
flake8...................................................................Failed

hook id: flake8

exit code: 1

tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271

@XuChen-MSFT This PR mssonicbld#1 is to fix pre-commit failure, I don't have write access of mssonicbld:cherry/202311/10838

Hi @zhixzhu better re-create manually double-commit for #10838, rather than create an additional patch for this automate PR.

PR to double commit: #14584

mssonicbld · 2024-09-14T01:53:58Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-09-14T01:54:08Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-09-14T01:54:59Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271 flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-09-17T01:36:47Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-09-17T01:36:57Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-09-17T01:37:49Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/qos/qos_sai_base.py:2317:5: F811 redefinition of unused 'skip_longlink' from line 2271 flake8...............................................(no files to check)Skipped check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-11-09T01:55:07Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-11-09T01:55:28Z

Pull request contains merge conflicts.

mssonicbld · 2024-11-12T01:58:55Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-11-12T01:59:16Z

Pull request contains merge conflicts.

zhixzhu · 2024-11-12T17:33:48Z

For 202311, manually cherry pick by PR #14584
Please close this PR. @XuChen-MSFT

mssonicbld · 2025-01-16T01:55:50Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2025-01-16T01:55:56Z

Pull request contains merge conflicts.

mssonicbld · 2025-01-17T01:55:26Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2025-01-17T01:55:32Z

Pull request contains merge conflicts.

mssonicbld · 2025-01-18T01:52:59Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2025-01-18T01:53:05Z

Pull request contains merge conflicts.

mssonicbld · 2025-01-21T01:56:15Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2025-01-21T01:56:21Z

Pull request contains merge conflicts.

[T2] Add case to test lossy fair-voq (sonic-net#10838)

f0523e8

1, Add a new case to test lossy fair-voq. 2, Add lossy_queue_voq_2 and lossy_queue_voq_3 to qos_param_generator.py. Default-voq and fair-voq will pass lossy_queue_voq_2, fair-voq and split-voq will pass lossy_queue_voq_3.

mssonicbld added the automerge label Sep 6, 2024

mssonicbld mentioned this pull request Sep 6, 2024

[T2] Add case to test lossy fair-voq #10838

Merged

7 tasks

XuChen-MSFT approved these changes Sep 11, 2024

View reviewed changes

XuChen-MSFT reviewed Sep 12, 2024

View reviewed changes

XuChen-MSFT mentioned this pull request Sep 13, 2024

Fix pre-commit failure of https://github.com/sonic-net/sonic-mgmt/pull/14447 mssonicbld/sonic-mgmt#1

Open

6 tasks

[action] [PR:10838] [T2] Add case to test lossy fair-voq #14447

Are you sure you want to change the base?

[action] [PR:10838] [T2] Add case to test lossy fair-voq #14447

Conversation

mssonicbld commented Sep 6, 2024

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented Sep 6, 2024

mssonicbld commented Sep 6, 2024

kevinskwang commented Sep 6, 2024 • edited Loading

mssonicbld commented Sep 7, 2024

azure-pipelines bot commented Sep 7, 2024

mssonicbld commented Sep 7, 2024

mssonicbld commented Sep 9, 2024

azure-pipelines bot commented Sep 9, 2024

mssonicbld commented Sep 9, 2024

zhixzhu commented Sep 9, 2024 • edited Loading

mssonicbld commented Sep 10, 2024

azure-pipelines bot commented Sep 10, 2024

mssonicbld commented Sep 10, 2024

XuChen-MSFT left a comment

Choose a reason for hiding this comment

XuChen-MSFT Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

zhixzhu Sep 12, 2024

Choose a reason for hiding this comment

XuChen-MSFT Sep 13, 2024

Choose a reason for hiding this comment

zhixzhu Sep 13, 2024

Choose a reason for hiding this comment

mssonicbld commented Sep 14, 2024

azure-pipelines bot commented Sep 14, 2024

mssonicbld commented Sep 14, 2024

mssonicbld commented Sep 17, 2024

azure-pipelines bot commented Sep 17, 2024

mssonicbld commented Sep 17, 2024

mssonicbld commented Nov 9, 2024

azure-pipelines bot commented Nov 9, 2024

mssonicbld commented Nov 12, 2024

azure-pipelines bot commented Nov 12, 2024

zhixzhu commented Nov 12, 2024 • edited Loading

mssonicbld commented Jan 16, 2025

azure-pipelines bot commented Jan 16, 2025

mssonicbld commented Jan 17, 2025

azure-pipelines bot commented Jan 17, 2025

mssonicbld commented Jan 18, 2025

azure-pipelines bot commented Jan 18, 2025

mssonicbld commented Jan 21, 2025

azure-pipelines bot commented Jan 21, 2025

kevinskwang commented Sep 6, 2024 •

edited

Loading

zhixzhu commented Sep 9, 2024 •

edited

Loading

XuChen-MSFT Sep 12, 2024 •

edited

Loading

zhixzhu commented Nov 12, 2024 •

edited

Loading