[Snappi] Adding Ungraceful Restart script for BGP Outbound cases

[selldinesh]

Description of PR

Summary:Adding Ungraceful Restart script as part of BGP Outbound cases
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405

Approach

What is the motivation for this PR?

To add Ungraceful restart case

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:187:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:188:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:189:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:190:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:191:51: E128 continuation line under-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/snappi_tests/multidut/bgp/files/bgp_outbound_helper.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snappi_tests/multidut/bgp/files/bgp_outbound_helper.py:1435:121: E501 line too long (124 > 120 characters)
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:187:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:188:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:189:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:190:51: E128 continuation line under-indented for visual indent
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/snappi_tests/multidut/bgp/files/bgp_outbound_helper.py:1435:121: E501 line too long (124 > 120 characters)
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:187:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:188:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:189:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:190:51: E128 continuation line under-indented for visual indent
tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:191:51: E128 continuation line under-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[deepak-singhal0408]

/Azpw run Azure.sonic-mgmt

[deepak-singhal0408]

/azpw run Azure.sonic-mgmt

[deepak-singhal0408]

@selldinesh can you make changes to this PR to ensure that it runs after the multi hw_platform support changes? For reference please refer changes in test_bgp_outbound_tsa.py

Btw, I have validated this PR after making above changes and it runs fine..
Once you make the change we can go ahead and merge this.. Sorry for delay...

[mssonicbld]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[mssonicbld]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[mssonicbld]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[mssonicbld]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[selldinesh]

@deepak-singhal0408 added changes with hw_platform support

[mssonicbld]

/azp run

[azure-pipelines]

Pull request contains merge conflicts.

[mssonicbld]

/azp run