Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case to verify AZNG Migration for T2 topology #14888

Merged
merged 44 commits into from
Oct 22, 2024

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Oct 8, 2024

What I did:

Added new test case to verify AZNG Migration for T2 topology. Test will run for MSFT internal image only.
Test verify after each step of AZNG Migration route-map functionality is as expected.
Test cover both v4 and v6 scenarios.
MSFT ADO: 29397531

How I verify:
Test passed on T2 topology.

abdosi and others added 30 commits February 5, 2021 17:00
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
chassis

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
as we are seding packet > 4k in some cases where there is HBM involved
to fill the buffer faster.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi and others added 11 commits March 7, 2024 00:43
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
… to APP DB modify route consistency

test to make sure all upstream LC;s have same route and all downstream LC's have same route.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
and to test route-map functionality is working fine as expected.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/bgp/test_bgp_azng_migration.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/bgp/test_bgp_azng_migration.py:13:1: E302 expected 2 blank lines, found 1
tests/bgp/test_bgp_azng_migration.py:20:17: E221 multiple spaces before operator
tests/bgp/test_bgp_azng_migration.py:46:8: E111 indentation is not a multiple of 4
tests/bgp/test_bgp_azng_migration.py:88:56: E222 multiple spaces after operator
tests/bgp/test_bgp_azng_migration.py:91:56: E222 multiple spaces after operator
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi merged commit 6c8cdbd into sonic-net:master Oct 22, 2024
16 checks passed
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
…4888)

Added new test case to verify AZNG Migration for T2 topology. Test will run for MSFT internal image only.
Test verify after each step of AZNG Migration route-map functionality is as expected.
Test cover both v4 and v6 scenarios.
@rlhui rlhui added the chassis label Nov 27, 2024
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 27, 2024
…4888)

Added new test case to verify AZNG Migration for T2 topology. Test will run for MSFT internal image only.
Test verify after each step of AZNG Migration route-map functionality is as expected.
Test cover both v4 and v6 scenarios.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15779

mssonicbld pushed a commit that referenced this pull request Nov 27, 2024
Added new test case to verify AZNG Migration for T2 topology. Test will run for MSFT internal image only.
Test verify after each step of AZNG Migration route-map functionality is as expected.
Test cover both v4 and v6 scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants