-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] [PR:13637] Multi-asic support for snmp_queue_counters test #15220
Conversation
Approach What is the motivation for this PR? Currently, 'test_snmp_queue_counters' test doesn't have multi-asic support and the test is failing for multi-asic chassis due to the lack of support. How did you do it? Added multi-asic support for test 'test_snmp_queue_counters' and made sure the current test logic is not affected. How did you verify/test it? Ran the above-mentioned test case on a T2 chassis and verified.
Original PR: #13637 |
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
hi @SuvarnaMeenakshi could you help to take a look? |
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
@rajendrat please take a look into the failure of snmp on ma PR test |
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi folks, I was working on some other issues in this script and realized there are some issues in multi-asic interface selection even in master which i fixed using following PR - #15688 The changes i made will also fix the issue this patch is facing while merging . So i have created a consolidated PR for 202405 which includes changes from this PR plus my PR which i mentioned above together. 202405 PR with Fix - |
Someone please close this PR given #15735 having these changes has merged. |
Yes, please close this PR as #15735 has taken care of fixes to 202405 branch and it got merged already. Verified the same. |
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation