[macsec/test_dataplane]: Add macsec counter clear test

[liamkearney-msft]

Description of PR

Add test for macsec counters clear command.

Summary:
Fixes #13347

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• [x ] Test case(new/improvement)

Back port request

• 202012
• 202205
• 202305
• 202311
• [ x] 202405

Approach

What is the motivation for this PR?

Fix test gap by adding sonic-clear macsec tests

How did you verify/test it?

Ran locally on t2 chassis, test passes

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[rlhui]

@liamkearney-msft please resolve conflicts? Thanks.

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/macsec/test_dataplane.py:10:1: F401 'tests.common.macsec.macsec_helper.get_macsec_sa_name' imported but unused
tests/macsec/test_dataplane.py:215:9: F821 undefined name 'clear_macsec_counters'

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[liamkearney-msft]

@rlhui conflicts have been resolved

[arlakshm]

@judyjoseph, please help signoff this change

[judyjoseph]

@liamkearney-msft could you add a test run PASS o/p result -- for the test_counters() and new test test_clear_counters() in the PR description?

[liamkearney-msft]

@judyjoseph I have run these tests locally and clear counters works on latest 20240510.17 build. test_counters is failing but its due to a regression unrelated to these changes.

[bingwang-ms]

@liamkearney-msft Is the new test test_clear_counters for T2 only or for T0 and T2? Can you paste the test result to the PR since it's a new test?

[liamkearney-msft]

Hi @bingwang-ms , this test should be topo agnostic.
Ive run these tests manually on both arista 7800 & nokia 7250, and it passes :

04:10:41 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
=============================================================== 1 passed, 1 warning in 953.59s (0:15:53) ===============================================================
DEBUG:tests.conftest:[log_custom_msg] item: <Function test_clear_counters[MACSEC_PROFILE]>