-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_lldp_syncd.py: Provide enough ready time for flap, restart, and reboot testcases #15277
Conversation
* Fix assert_lldp_entry_content() to only check mandate lldp attributes Singed-off-by: lumhl@hotmail.com
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Description of PR
Provide enough ready time for flap, restart, and reboot testcases.
For flap testcase, sometimes get_lldp_entry_content() will return empty entry content even though the testcase has just verified the entry content using the same function. It seems we need to provide enough time for the DB object to be ready again for query. Also increase wait_until() timeout from 60 seconds to 120 seconds.
For restart testcase, increase wait_until() timeout from 60 seconds to 120 seconds.
For reboot testcase, DB takes more time to be ready after DUT/LLDP is up, thus adding a verify DB keys assertion check after DUT rebooted before proceeding to the rest of the assertion checks.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fixing testcode.
How did you do it?
Explained above.
How did you verify/test it?
Tested on HW topo.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation