Snmp fixes - test_snmp_default_route and test_snmp_queue_counters #15279
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanjair-git, can you please resolve the conflicts |
sanjair-git
force-pushed
the
snmp-fixes
branch
from
4232099 to
5d983a4
Compare
Done @arlakshm. Thanks |
arlakshm
approved these changes
Nov 28, 2024
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 29, 2024
…unters (sonic-net#15279) Summary: This PR fixes test issue introduced as part of sonic-net#3537 for test_snmp_default_route test, and General fix for test_snmp_queue_counters test teardown. Type of change Approach What is the motivation for this PR? After PR sonic-net#3537 introduction, CLI command output for 'show ip route 0.0.0.0/0' has been changed and a new word 'recursive' gets added. Hence sonic-mgmt needs to be modified to support this new change. For example, "* 11.0.0.145 recursive via iBGP" During teardown of 'test_snmp_queue_counters' test, sometimes we see the following error while recopying the config_db json file for the duthost. E tests.common.errors.RunAnsibleModuleFail: run module copy failed, Ansible Results => E {"changed": false, "failed": true, "msg": "Source /etc/sonic/orig_config_db1.json not found"} complex_args = {'dest': '/etc/sonic/config_db1.json', 'remote_src': True, 'src': '/etc/sonic/orig_config_db1.json'} filename = '/data/tests/snmp/test_snmp_queue_counters.py' function_name = 'teardown' How did you do it? Handle 'recursive' word as well while parsing for ip-address in test_snmp_default_route test case. Make sure the duthost is same during test call and teardown in test_snmp_queue_counters test case. How did you verify/test it? Ran all the above-mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.
|
@sanjair-git Does this change impact non-T2 platform? Since if |
It is not impacted. For T0 & T1 platforms, I could see 'test_snmp_default_route' test passing. |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 17, 2024
…unters (sonic-net#15279) Summary: This PR fixes test issue introduced as part of sonic-net#3537 for test_snmp_default_route test, and General fix for test_snmp_queue_counters test teardown. Type of change Approach What is the motivation for this PR? After PR sonic-net#3537 introduction, CLI command output for 'show ip route 0.0.0.0/0' has been changed and a new word 'recursive' gets added. Hence sonic-mgmt needs to be modified to support this new change. For example, "* 11.0.0.145 recursive via iBGP" During teardown of 'test_snmp_queue_counters' test, sometimes we see the following error while recopying the config_db json file for the duthost. E tests.common.errors.RunAnsibleModuleFail: run module copy failed, Ansible Results => E {"changed": false, "failed": true, "msg": "Source /etc/sonic/orig_config_db1.json not found"} complex_args = {'dest': '/etc/sonic/config_db1.json', 'remote_src': True, 'src': '/etc/sonic/orig_config_db1.json'} filename = '/data/tests/snmp/test_snmp_queue_counters.py' function_name = 'teardown' How did you do it? Handle 'recursive' word as well while parsing for ip-address in test_snmp_default_route test case. Make sure the duthost is same during test call and teardown in test_snmp_queue_counters test case. How did you verify/test it? Ran all the above-mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.
|
Cherry-pick PR to 202405: #16103 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 17, 2024
…unters (#15279) Summary: This PR fixes test issue introduced as part of #3537 for test_snmp_default_route test, and General fix for test_snmp_queue_counters test teardown. Type of change Approach What is the motivation for this PR? After PR #3537 introduction, CLI command output for 'show ip route 0.0.0.0/0' has been changed and a new word 'recursive' gets added. Hence sonic-mgmt needs to be modified to support this new change. For example, "* 11.0.0.145 recursive via iBGP" During teardown of 'test_snmp_queue_counters' test, sometimes we see the following error while recopying the config_db json file for the duthost. E tests.common.errors.RunAnsibleModuleFail: run module copy failed, Ansible Results => E {"changed": false, "failed": true, "msg": "Source /etc/sonic/orig_config_db1.json not found"} complex_args = {'dest': '/etc/sonic/config_db1.json', 'remote_src': True, 'src': '/etc/sonic/orig_config_db1.json'} filename = '/data/tests/snmp/test_snmp_queue_counters.py' function_name = 'teardown' How did you do it? Handle 'recursive' word as well while parsing for ip-address in test_snmp_default_route test case. Make sure the duthost is same during test call and teardown in test_snmp_queue_counters test case. How did you verify/test it? Ran all the above-mentioned test cases on a T2 chassis and made sure tests passed with expected behavior.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation