Updating techsupport commands to include optimized bgp neighbor commands #15466

dgsudharsan · 2024-11-08T04:06:25Z

Description of PR

Summary:
Fixes # (issue)

DO NOT MERGE until sonic-net/sonic-utilities#3605 is merged and submodule is updated.
Update techsupport test to align with this PR sonic-net/sonic-utilities#3605

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

To support covering show techsupport after the enhancement introduced in sonic-net/sonic-utilities#3605

How did you do it?

Used regex to modify the validations to align with the new optimized vtysh command in the show techsupport

How did you verify/test it?

Running the test with sonic-utilities changes

Any platform specific information?

This is platfrm agnostic chhanges.

Supported testbed topology if it's a new test case?

Not a new test case

Documentation

mssonicbld · 2024-11-08T04:07:09Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/show_techsupport/tech_support_cmds.py:119:121: E501 line too long (121 > 120 characters) flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2024-11-08T04:56:16Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/show_techsupport/tech_support_cmds.py:118:77: E502 the backslash is redundant between brackets tests/show_techsupport/tech_support_cmds.py:119:17: E127 continuation line over-indented for visual indent tests/show_techsupport/tech_support_cmds.py:120:79: E502 the backslash is redundant between brackets tests/show_techsupport/tech_support_cmds.py:121:17: E127 continuation line over-indented for visual indent flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

FengPan-Frank · 2024-12-12T08:36:12Z

tests/show_techsupport/tech_support_cmds.py

-    re.compile(r'vtysh{}\s+-c "show ip bgp neighbors .* routes"'),
-    re.compile(r'vtysh{}\s+-c "show bgp ipv6 neighbors .* advertised-routes"'),
-    re.compile(r'vtysh{}\s+-c "show bgp ipv6 neighbors .* routes"'),
+    re.compile(r"vtysh(\s+-Ec 'show bgp ipv4 neighbors .* advertised-routes' "


does wildcard support here?

Can you clarify your question? It does work with the changes in the sonic-utilities PR.

no issue, I just remember this was not supported, sorry maybe I missed.

Can you please approve if all good?

mssonicbld · 2024-12-18T00:58:46Z

/azp run

azure-pipelines · 2024-12-18T00:58:57Z

Azure Pipelines successfully started running 1 pipeline(s).

FengPan-Frank

LGTM, pls fix pre-checkin test issue.

dgsudharsan · 2024-12-19T02:40:18Z

/azpw run Azure.sonic-mgmt

mssonicbld · 2024-12-19T02:40:20Z

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines · 2024-12-19T02:40:31Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2024-12-20T20:56:56Z

/azpw run Azure.sonic-mgmt

mssonicbld · 2024-12-20T20:56:58Z

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines · 2024-12-20T20:57:09Z

Azure Pipelines successfully started running 1 pipeline(s).

This PR should be followed by #15466. There is a circular dependency where the sonic-utilities submodule after this change sonic-net/sonic-utilities#3605 will not get update unless show techsupport test pass. However the test cannot pass until we have sonic-utilities submodule updated. To overcome this create a temporary PR to remove the techsupport commands that create this dependency. After the submodule update is done #15466 can be merged

mssonicbld · 2024-12-23T17:21:09Z

/azp run

azure-pipelines · 2024-12-23T17:21:21Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-12-24T17:33:49Z

/azp run

azure-pipelines · 2024-12-24T17:34:01Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2024-12-25T01:39:15Z

/azp run

azure-pipelines · 2024-12-25T01:39:26Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2024-12-25T01:40:53Z

Test failed because the test in run with "build_version": "master.728471-af18b144e",
which doesn't contain the required sonic-utilities changes. Once the master build is updated in pipelines the test should pass

mssonicbld · 2024-12-26T05:44:01Z

/azp run

azure-pipelines · 2024-12-26T05:44:15Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2025-01-02T05:02:14Z

@yxieca @maipbui @FengPan-Frank Can you please help merge?

yxieca · 2025-01-02T18:52:44Z

@dgsudharsan can you please update the PR template:

What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?

dgsudharsan · 2025-01-02T21:51:14Z

@yxieca Done.

Updating techsupport commands to include optimized bgp neighbor commands

8db36c2

dgsudharsan requested a review from yxieca as a code owner November 8, 2024 04:06

dgsudharsan mentioned this pull request Nov 8, 2024

Optimize techsupport reducing number of vtysh calls in scale sceario sonic-net/sonic-utilities#3605

Merged

Fixing static analysis

646443d

dgsudharsan added 2 commits November 8, 2024 21:58

Fixing precommit issues

8b76fe8

Update tech_support_cmds.py

3668514

FengPan-Frank reviewed Dec 12, 2024

View reviewed changes

Merge branch 'sonic-net:master' into optimize_ts

7bab24b

FengPan-Frank approved these changes Dec 18, 2024

View reviewed changes

dgsudharsan added the Request for 202411 branch label Dec 18, 2024

This was referenced Dec 21, 2024

Removing bpg commands to resolve circular dependency #16195

Merged

Revert "Optimize techsupport reducing number of vtysh calls in scale sceario" sonic-net/sonic-utilities#3694

Closed

Merge branch 'master' into optimize_ts

eb665ce

maipbui approved these changes Dec 23, 2024

View reviewed changes

Fixing test issue

c4a262c

Merge branch 'sonic-net:master' into optimize_ts

8f9cf36

Merge branch 'sonic-net:master' into optimize_ts

a32f897

yxieca merged commit 6f45beb into sonic-net:master Jan 2, 2025
17 checks passed

dgsudharsan added Request for msft-202412 branch and removed Request for 202411 branch labels Jan 3, 2025

r12f added the Approved for msft-202412 branch label Jan 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating techsupport commands to include optimized bgp neighbor commands #15466

Updating techsupport commands to include optimized bgp neighbor commands #15466

dgsudharsan commented Nov 8, 2024 •

edited

Loading

mssonicbld commented Nov 8, 2024

mssonicbld commented Nov 8, 2024

FengPan-Frank Dec 12, 2024

dgsudharsan Dec 16, 2024

FengPan-Frank Dec 17, 2024

dgsudharsan Dec 17, 2024

mssonicbld commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

FengPan-Frank left a comment

dgsudharsan commented Dec 19, 2024

mssonicbld commented Dec 19, 2024

azure-pipelines bot commented Dec 19, 2024

dgsudharsan commented Dec 20, 2024

mssonicbld commented Dec 20, 2024

azure-pipelines bot commented Dec 20, 2024

mssonicbld commented Dec 23, 2024

azure-pipelines bot commented Dec 23, 2024

mssonicbld commented Dec 24, 2024

azure-pipelines bot commented Dec 24, 2024

mssonicbld commented Dec 25, 2024

azure-pipelines bot commented Dec 25, 2024

dgsudharsan commented Dec 25, 2024

mssonicbld commented Dec 26, 2024

azure-pipelines bot commented Dec 26, 2024

dgsudharsan commented Jan 2, 2025

yxieca commented Jan 2, 2025

dgsudharsan commented Jan 2, 2025

Updating techsupport commands to include optimized bgp neighbor commands #15466

Updating techsupport commands to include optimized bgp neighbor commands #15466

Conversation

dgsudharsan commented Nov 8, 2024 • edited Loading

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

mssonicbld commented Nov 8, 2024

mssonicbld commented Nov 8, 2024

FengPan-Frank Dec 12, 2024

Choose a reason for hiding this comment

dgsudharsan Dec 16, 2024

Choose a reason for hiding this comment

FengPan-Frank Dec 17, 2024

Choose a reason for hiding this comment

dgsudharsan Dec 17, 2024

Choose a reason for hiding this comment

mssonicbld commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

FengPan-Frank left a comment

Choose a reason for hiding this comment

dgsudharsan commented Dec 19, 2024

mssonicbld commented Dec 19, 2024

azure-pipelines bot commented Dec 19, 2024

dgsudharsan commented Dec 20, 2024

mssonicbld commented Dec 20, 2024

azure-pipelines bot commented Dec 20, 2024

mssonicbld commented Dec 23, 2024

azure-pipelines bot commented Dec 23, 2024

mssonicbld commented Dec 24, 2024

azure-pipelines bot commented Dec 24, 2024

mssonicbld commented Dec 25, 2024

azure-pipelines bot commented Dec 25, 2024

dgsudharsan commented Dec 25, 2024

mssonicbld commented Dec 26, 2024

azure-pipelines bot commented Dec 26, 2024

dgsudharsan commented Jan 2, 2025

yxieca commented Jan 2, 2025

dgsudharsan commented Jan 2, 2025

dgsudharsan commented Nov 8, 2024 •

edited

Loading