[action] [PR:15331] [202405] Fix intermittent issue on reboot in test_lldp_syncd #15535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the start of test_lldp_syncd.py::test_lldp_entry_table_after_reboot the test polls and checks that LLDP_ENTRY_TABLE keys match show lldp table output. The eth0 port is added last so sometimes the entry keys will have it but the lldp table output will not. From debugging, this is the case since the end of the previous test (I put a check on the keys vs lldp table output and observed the missing eth0 at the end of test_lldp_syncd.py::test_lldp_entry_table_after_lldp_restart) Added a wait_until at the start of test_lldp_entry_table_after_reboot to wait until the LLDP_ENTRY_TABLE keys match show lldp table output before the tests starts to reboot.
8 tasks
|
Original PR: #15331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
At the start of
test_lldp_syncd.py::test_lldp_entry_table_after_rebootthe test polls and checks that LLDP_ENTRY_TABLE keys match show lldp table output.The
eth0port is added last so sometimes the entry keys will have it but the lldp table output will not. From debugging, this is the case since the end of the previous test (I put a check on the keys vs lldp table output and observed the missingeth0at the end oftest_lldp_syncd.py::test_lldp_entry_table_after_lldp_restart). From our test results, this issue hits both fixed and modular, but appears to be more easily reproduced on fixed systems.Added a wait_until at the start of
test_lldp_entry_table_after_rebootto wait until the LLDP_ENTRY_TABLE keys match show lldp table output before the tests starts to reboot.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Observed another intermittent issue in
test_lldp_syncdin addition to the issues fixed by #15258.How did you do it?
How did you verify/test it?
Verified the test on one of our fixed system by running test 50 times with this change and PR#15258 to ensure all the intermittent fails are gone.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation