Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snappi][master only] add enum with completeness_level back in #15538

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[snappi][master only] add enum with completeness_level back in #15538

merged 2 commits into from
Nov 13, 2024

Conversation

sdszhang
Copy link
Contributor

@sdszhang sdszhang commented Nov 13, 2024 •
edited
Loading

Description of PR

Summary:
The fix in #15057 was overwritten by recent changes. This PR add it back into master. #15539 add it back into 202405.
Will open another PR for 202405 as the fix will be slight different.

  1. test_pfc_pause_single_lossless_prio_reboot:

    • the parameter/fixture sequence is different between master and 202405 branch.
    • this change moves the enum_dut_lossless_prio_with_completeness_level back to original position. so it will be same as 202405 branch.

  2. test_pfc_pause_single_lossy_prio_reboot:

    • add enum_dut_lossy_prio_with_completeness_level back in.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

add PR #15057 back into master.

How did you do it?

How did you verify/test it?

tested it locally.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@sdszhang sdszhang changed the title [snappi] add enum with completeness_level back in [snappi] add enum with completeness_level back in (master only) Nov 13, 2024
@sdszhang sdszhang changed the title [snappi] add enum with completeness_level back in (master only) [snappi] add enum with completeness_level back in [master only] Nov 13, 2024
@sdszhang sdszhang changed the title [snappi] add enum with completeness_level back in [master only] [snappi][master only] add enum with completeness_level back in Nov 13, 2024
@sdszhang sdszhang mentioned this pull request Nov 13, 2024
Merged
8 tasks
@sdszhang
Copy link
Contributor Author

@rraghav-cisco for review.

@sdszhang
Copy link
Contributor Author

test result:

snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxx-lc4-1|3] SKIPPED [  5%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxx-lc4-1|4] SKIPPED [ 10%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxxx-lc2-1|3] SKIPPED [ 15%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxx-lc2-1|4] SKIPPED [ 21%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxx-sup-1|3] SKIPPED [ 26%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxx-sup-1|4] SKIPPED [ 31%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_counter_check[xxxlc4-1|3] SKIPPED [ 36%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_counter_check[xxlc4-1|4] SKIPPED [ 42%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_counter_check[xxx-lc2-1|3] SKIPPED [ 47%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_counter_check[xxx-lc2-1|4] SKIPPED [ 52%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_counter_check[xxx-sup-1|3] SKIPPED [ 57%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_counter_check[xxx-sup-1|4] SKIPPED [ 63%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio SKIPPED [ 68%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio_reboot[warm] SKIPPED [ 73%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio_reboot[cold] SKIPPED [ 78%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio_reboot[fast] SKIPPED [ 84%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio_reboot[warm] SKIPPED [ 89%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio_reboot[cold] SKIPPED [ 94%]
snappi_tests/pfc/test_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio_reboot[fast] SKIPPED [100%]


snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[xxx-1|3]  PASSED                                                                   [  7%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[multidut_port_info0-xxxlc4-1|4] PASSED [ 15%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[multidut_port_info0-xxx-lc2-1|3] PASSED [ 23%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[multidut_port_info0-xxx-lc2-1|4] PASSED [ 30%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[multidut_port_info0-xxxsup-1|3] PASSED [ 38%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio[multidut_port_info0-xxx-sup-1|4] PASSED [ 46%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio[multidut_port_info0] PASSED [ 53%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio_reboot[multidut_port_info0-warm-xxxlc2-1|4] SKIPPED [ 61%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio_reboot[multidut_port_info0-cold-xxxlc2-1|4] PASSED [ 69%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_single_lossless_prio_reboot[multidut_port_info0-fast-xxx-lc2-1|4] SKIPPED [ 76%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio_reboot[multidut_port_info0-warm] SKIPPED [ 84%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio_reboot[multidut_port_info0-cold] PASSED [ 92%]
snappi_tests/multidut/pfc/test_multidut_pfc_pause_lossless_with_snappi.py::test_pfc_pause_multi_lossless_prio_reboot[multidut_port_info0-fast] SKIPPED [100%]

rraghav-cisco
rraghav-cisco approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rraghav-cisco rraghav-cisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abdosi abdosi merged commit b005182 into sonic-net:master Nov 13, 2024
15 checks passed
yejianquan pushed a commit that referenced this pull request Nov 14, 2024
@sdszhang
[snappi][202405] add enum with completeness_level back in (#15539)
c41f4af 
Description of PR
Summary:
The fix in #15057 was overwritten by recent changes. This PR add it back into 202405. #15538 added for master.

test_pfc_pause_single_lossless_prio_reboot:

remove unused enum_dut_lossless_prio, keep only enum_dut_lossless_prio_with_completeness_level
test_pfc_pause_single_lossy_prio_reboot:

add enum_dut_lossy_prio_with_completeness_level back in.

Approach
What is the motivation for this PR?
add PR #15057 back into 202405.

How did you do it?
How did you verify/test it?
tested it locally.

co-authorized by: jianquanye@microsoft.com
sreejithsreekumaran pushed a commit to sreejithsreekumaran/sonic-mgmt that referenced this pull request Nov 15, 2024
@sdszhang @sreejithsreekumaran
[snappi][master only] add enum with completeness_level back in (sonic…
5c9c259 
…-net#15538)

Summary:
The fix in sonic-net#15057 was overwritten by recent changes. This PR add it back into master. sonic-net#15539 add it back into 202405.
Will open another PR for 202405 as the fix will be slight different.

test_pfc_pause_single_lossless_prio_reboot:

the parameter/fixture sequence is different between master and 202405 branch.
this change moves the enum_dut_lossless_prio_with_completeness_level back to original position. so it will be same as 202405 branch.
test_pfc_pause_single_lossy_prio_reboot:

add enum_dut_lossy_prio_with_completeness_level back in.
yutongzhang-microsoft pushed a commit to yutongzhang-microsoft/sonic-mgmt that referenced this pull request Nov 21, 2024
@sdszhang @yutongzhang-microsoft
[snappi][master only] add enum with completeness_level back in (sonic…
3c247a6 
…-net#15538)

Summary:
The fix in sonic-net#15057 was overwritten by recent changes. This PR add it back into master. sonic-net#15539 add it back into 202405.
Will open another PR for 202405 as the fix will be slight different.

test_pfc_pause_single_lossless_prio_reboot:

the parameter/fixture sequence is different between master and 202405 branch.
this change moves the enum_dut_lossless_prio_with_completeness_level back to original position. so it will be same as 202405 branch.
test_pfc_pause_single_lossy_prio_reboot:

add enum_dut_lossy_prio_with_completeness_level back in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rraghav-cisco rraghav-cisco rraghav-cisco approved these changes

@abdosi abdosi abdosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdszhang @abdosi @rraghav-cisco