Add extra logic in test_sfputil to make sure modules are restored #13108 #15543
+315
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nic-net#13108) * Add extra logic in test_sfputil to make sure modules are restored * Fix flake8 E125 * Use config dom enable/disable * flake8 fix * Use context manager and remove unnecessary sleep * Handle breakout case propperly and increase wait_time * Add skip for lpmode handling and fix for breakout * Restore dom_polling to origional * Add comments * Add lpmode on/off seq, remove lpmode restore logic and avoid starting admin-down ports * Fix typo for lpmode on/off
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Manual cherry-pick of #13108 to 202405 branch
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation