Add fail if startup tsa tsb timer file can't be found #15548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if startup tsa tsb service is not supported * Add pytest skip if startup tsa tsb service is not supported when attempting to get startup timer Signed-off-by: Javier Tan javiertan@microsoft.com
arista-nwolfe
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Looks good to me, thanks @Javier-Tan for fixing this.
Could we add @sanjair-git, who introduced this test, as a reviewer as well?
|
Hi @Javier-Tan, thanks for change. We do not want to skip this test. I tests were failing because the service files were missing. I have added the Arista Linecard platforms files in this PR sonic-net/sonic-buildimage#20804 |
Hi @arlakshm, should we change the skip to fail if we assume startup tsa tsb is always supported? |
Javier-Tan
changed the title
Javier-Tan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #15513
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix errors caused by startup_tsa_tsb_service being expected but not supported
How did you do it?
Add a skip when trying to get startup tsb timer, function now doubles as a check if start_tsa_tsb_service is supported.
How did you verify/test it?
Test that skip applies to applicable tests when startup tsa tsb service is not detected, and rest of tests are not affected
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A