[action] [PR:15536] fix 7260 headroom pool watermark test failure #15555
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
observed consistent headroom wartermark test failure on 7260
and it's known issue of test script, as below RCA:
RCA:
summarize test step first:
after step2,
already send 20 pkts into headroom to trigger PFC on 10 src ports (20 PG)
but, so far, "upper_bound" value is static hardcode "2 LICENSE README.md SECURITY.md ansible azure-pipelines.yml docs git pyproject.toml sdn_tests setup-container.sh spytest test_reporting tests margin + 1", didn't consider headroom pool consumption in step2.
since we use dynamically threshold calculating, it can get accurate threshold value, we pretty sure the headroom pool consumption equal "pgs_num" in step2.
so I change "upper_bound" value to "2 LICENSE README.md SECURITY.md ansible azure-pipelines.yml docs git pyproject.toml sdn_tests setup-container.sh spytest test_reporting tests margin + self.pgs_num", and it pass the tests.
How did you do it?
change "upper_bound" value to "2 LICENSE README.md SECURITY.md ansible azure-pipelines.yml docs git pyproject.toml sdn_tests setup-container.sh spytest test_reporting tests margin + self.pgs_num"
How did you verify/test it?
this change already verified in MSFT nightly for 202305 and 202311 branch, just commit to github.
Any platform specific information?
this change is dedicated to below platform and topology:
if other platform and topology have hit similar issue, can add affected platform and topo to above condition checking.
Note:
for generic fix, qos refactor project will covert.
Supported testbed topology if it's a new test case?
Documentation