Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:15272] Skipping test_static_route on Cisco 8122 #15576

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mssonicbld
Copy link
Collaborator

What is the motivation for this PR?
All 3 tests in test_static_route are failing on 8122.
Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent.
“show flowcnt-route stats“ does not show the test pkt because counter config itself failed.
Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122.
'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile).

As the feature is not enabled for this platform, need to skip this testcase

How did you do it?
Added a skip condition for test_static_route for 8122 platform

Type of change
-Test modification

Back port request
-202311
-202405

How did you verify/test it?
Ran test_static_router.py on 8122 and verified it was skipped.

--------------------- generated xml file: /run_logs/ananshar/route/test_static_route_2024-10-21-03-14-31.xml ---------------------
INFO:root:Can not get Allure report URL. Please check logs

----------------------------------------------------- live log sessionfinish -----------------------------------------------------
03:14:52 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs
==================================================== short test summary info =====================================================
SKIPPED [2] route/test_static_route.py: Test not supported for 201911 images or older. Does not apply to standalone topos. Not supported on cisco-8122 platform
SKIPPED [1] route/test_static_route.py:350: Test not supported for 201911 images or older. Does not apply to standalone topos. Not supported on cisco-8122 platform
SKIPPED [1] route/test_static_route.py:371: Test not supported for 201911 images or older. Does not apply to standalone topos. Not supported on cisco-8122 platform
================================================= 4 skipped, 1 warning in 20.15s =================================================
sonic@sonic-ucs-m6-24:/data/tests$ 

What is the motivation for this PR?
All 3 tests in test_static_route are failing on 8122.
Tests are failing because “show flowcnt-route stats“ does not show the 1 test pkt that the test has sent.
“show flowcnt-route stats“ does not show the test pkt because counter config itself failed.
Counter config failed because FLOW_COUNTER_CAPABILITY was enabled recently on ASIC/SDK side for 8122 but 'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122.
'enable_forwarding_route_counter' is not enabled on SONiC/asic_cfg.json on 8122 because of scale limits (cannot scale more than 50k with the current LPM profile).

As the feature is not enabled for this platform, need to skip this testcase

How did you do it?
Added a skip condition for test_static_route for 8122 platform

Type of change

-Test modification

Back port request

-202311
-202405

How did you verify/test it?
Ran test_static_router.py on 8122 and verified it was skipped.
@mssonicbld
Copy link
Collaborator Author

Original PR: #15272

@mssonicbld mssonicbld merged commit 3e99804 into sonic-net:202405 Nov 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants