Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TSB startup tests to use reboot.py constants #15579

Conversation

Javier-Tan
Copy link
Contributor

Description of PR

Summary:
Replace duplicated constants in test_startup_tsa_tsb_service.py to use constants already defined in reboot.py

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

By using reboot types defined in reboot.py, increases consistency (less places to update, less potential for bugs), avoids needing to duplicate need reboot types.

How did you do it?

Import reboot.py constants into test file, replace associated values.

How did you verify/test it?

Ran affected tests on physical T2 testbed to ensure behaviour was correct

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

…e from reboot.py

* Update testfile to use reboot cause from reboot.py to help consistency and avoid redefining

Signed-off-by: Javier Tan javiertan@microsoft.com
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/bgp/test_startup_tsa_tsb_service.py:674:121: E501 line too long (133 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

* Reduce line lengths > 120

Signed-off-by: Javier Tan javiertan@microsoft.com
@Javier-Tan Javier-Tan closed this Jan 2, 2025
@Javier-Tan Javier-Tan deleted the tsb_startup_reuse_reboot_constants branch January 2, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants