You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a pfc_gen script for Arista DCS-7060X6 fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista DCS-7060X6 fanout devices running EOS.
Summary:
Fixes # (issue)
Type of change
Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)
Back port request
202012
202205
202305
202311
202405
Approach
What is the motivation for this PR?
Adds more reliable PFC storm generation for interfaces connected to Arista DCS-7060X6 fanout devices
How did you do it?
How did you verify/test it?
Ran the pfcwd tests on t1 switch with interfaces connected to Arista DCS-7060X6 device, ensured the new script was used and pfc storm was appropriately detected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Add a pfc_gen script that generates storm by directly setting PFC
backpressure status in hardware (using broadcom shell commands) and
modify pfc_storm to use this new script if the port is connected to th5
MPC. Intended to upstream for MSFT.
The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.
Detailed pre-commit check results: trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook
Fixing tests/common/helpers/pfc_gen_th5.py
fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1
tests/common/helpers/pfc_gen_th5.py:7:1: F401 'binascii' imported but unused tests/common/helpers/pfc_gen_th5.py:59:31: F541 f-string is missing placeholders tests/common/helpers/pfc_gen_th5.py:62:52: W605 invalid escape sequence 'S' tests/common/helpers/pfc_gen_th5.py:62:67: W605 invalid escape sequence '[' tests/common/helpers/pfc_gen_th5.py:62:75: W605 invalid escape sequence 'd' ... [truncated extra lines, please run pre-commit locally to view full check results]
To run the pre-commit checks locally, you can follow below steps:
Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:
sudo pip install pre-commit
Go to repository root folder
Install the pre-commit hooks:
pre-commit install
Use pre-commit to check staged file:
pre-commit
Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add a pfc_gen script for Arista DCS-7060X6 fanout devices to generate pfc pause frames by setting PFC backpressure status in hardware. Enable the storm generation to use this script on interfaces that are connected to Arista DCS-7060X6 fanout devices running EOS.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Adds more reliable PFC storm generation for interfaces connected to Arista DCS-7060X6 fanout devices
How did you do it?
How did you verify/test it?
Ran the pfcwd tests on t1 switch with interfaces connected to Arista DCS-7060X6 device, ensured the new script was used and pfc storm was appropriately detected.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation