Update acl test case to permit nic simulator keepalive path in dualtor-aa topology. #15619
Conversation
Permit nic simulator keepalive path Change-Id: I32212d2bf9406efe1228ede7e8083aff44fb2b2f
liat-grozovik
changed the title
| @@ -46,7 +47,7 @@ | |||
|
|
|||
| # TODO: We really shouldn't have two separate templates for v4 and v6, need to combine them somehow | |||
| ACL_RULES_FULL_TEMPLATE = { | |||
| "ipv4": "acltb_test_rules.j2", | |||
| "ipv4": "acltb_test_rules_permit_loopback.j2", | |||
There was a problem hiding this comment.
Why not add the loopback ACL rule to the original file?
There was a problem hiding this comment.
Hi @bingwang-ms , the acltb_test_rules.j2 has been shared by tests/ssh/test_ssh_stress.py too, if keep the change in the original file, it would affect tests/ssh/test_ssh_stress.py.
…r-aa topology. (sonic-net#15619) - How did you do it? Permit nic simulator keepalive path in dualtor-aa topology - How did you verify/test it? Run it in internal dualtor regression.
|
Cherry-pick PR to 202405: #15866 |
| @@ -25,6 +25,7 @@ | |||
| from tests.common.fixtures.conn_graph_facts import conn_graph_facts # noqa F401 | |||
| from tests.common.platform.processes_utils import wait_critical_processes | |||
| from tests.common.platform.interface_utils import check_all_interface_information | |||
| from tests.qos.tunnel_qos_remap_base import get_iface_ip | |||
There was a problem hiding this comment.
Hi, @echuawu, there are cross feature dependency, which means, we are not allowed to import functions from tests/qos in tests/acl, can you fix this issue?
There was a problem hiding this comment.
Hi, @echuawu, there are cross feature dependency, which means, we are not allowed to import functions from
tests/qosintests/acl, can you fix this issue?
Hi @yutongzhang-microsoft , is it proper to define a get_iface_ip function in test_acl.py?
There was a problem hiding this comment.
I think you can.
What is the motivation for this PR? In PR #15619, a cross-feature dependency was introduced in tests/acl/test_acl.py due to the usage of the get_iface_ip function. To address this issue and streamline the code structure, we have refactored the function and moved it to a common location. How did you do it? To address this issue and streamline the code structure, we have refactored the function and moved it to a common location. How did you verify/test it?
…r-aa topology. (#15619) - How did you do it? Permit nic simulator keepalive path in dualtor-aa topology - How did you verify/test it? Run it in internal dualtor regression.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Description of PR
Update acl test case to permit nic simulator keepalive path in dualtor-aa topology.
Summary:
Fixes # (issue)
#15206
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug fix - #15206
How did you do it?
Permit nic simulator keepalive path in dualtor-aa topology
How did you verify/test it?
Run it in internal dualtor regression.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation