[testbed-cli] Code change on add-topo and deploy-minigraph for deploying testbed with peers on multiple servers #15643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1nda
changed the title
8 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
reviewed
Dec 23, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
w1nda
commented
Dec 25, 2024
|
/azp run |
|
Pull request contains merge conflicts. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jan 18, 2025
r12f
approved these changes
Jan 18, 2025
|
@wangxin Could you please help review? |
wangxin
previously approved these changes
Jan 20, 2025
|
@w1nda Can you resolve merge conflicts? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Jan 20, 2025
11 tasks
Blueve
pushed a commit
that referenced
this pull request
Jan 23, 2025
…t.yml (#16634) Summary: Fixes # (issue) In PR: #15643, it add a new optional variable clean_before_add for template arista_7260_connect.j2 to indicate whether clean vlan range before add vlan range, however, this variable are defined in fanout_connect.yml which will call rootfanout_connect.yml, this will be a bug, because when rootfanout_connect.yml is called by other playbook, it will raise error: clean_before_add undefined, so, to fix this bug, we move the clean_before_add definition from fanout_connect.yml to rootfanout_connect.yml. What is the motivation for this PR? this will be a bug, because when rootfanout_connect.yml is called by other playbook, it will raise error: clean_before_add undefined How did you do it? move the clean_before_add definition from fanout_connect.yml to rootfanout_connect.yml. How did you verify/test it? local run playbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
In PR #15547, we define server index in topology file which make topology file and testbed yaml file is coupled.
To decouple them, in new design #15395, we remove server index in topology file and add dut_interfaces in testbed yaml, so there is no more change on topology file schema.
Type of change
Back port request
Approach
What is the motivation for this PR?
Decouple topology file and testbed file in design.
How did you do it?
Record all information in testbed schema
How did you verify/test it?
Deploy testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation