[action] [PR:15573] sonic-mgmt: fix port toggle timeout on many ports #15673
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For topologies leveraging many ports, such as in the case of t0-isolated-d128u128s2, the timeout for non-mellanox fixed-chassis devices is a static value and is too low for the number of ports being configured. In contrast, Mellanox devices use a timeout proportional to the number of ports being toggled. This change moves fixed-chassis broadcom devices to use a proportional timeout as well.
8 tasks
|
Original PR: #15573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: For topologies leveraging many ports, such as in the case of t0-isolated-d128u128s2, the timeout for non-Mellanox fixed-chassis devices is a static value and is too low for the number of ports being configured. This change moves fixed-chassis Broadcom devices to use a proportional timeout, same as what is currently done for Mellanox devices.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Change to a proportoinal port toggle timeout for fixed-chassis Broadcom devices, so that such devices with a large number of interfaces (as used in certain topos) can pass tests that utilize the common port_toggle helper.
How did you do it?
Extended the proprtional timeout functionality used for Mellanox devices to Broadcom devices as well (fixed-chassis only).
How did you verify/test it?
Ran the acl/test_acl.py::TestAclWithPortToggle tests and confirmed that they no longer fail.
Any platform specific information?
Verification run on Arista-7060X6-64PE-C256S2.