Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dualtor][test_bgp_session] Skip reboot test type on dualtor #15729

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Nov 25, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Skip the warm reboot test type, as it will leave the DUT in an error state, and causes failures of following cases:

bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-bgp_docker] PASSED [ 16%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-swss_docker] PASSED [ 33%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-reboot] FAILED [ 50%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-bgp_docker] FAILED [ 66%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-swss_docker] FAILED [ 83%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-reboot] FAILED [100%]

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

If test type is reboot (warm reboot), skip on dualtor.

How did you verify/test it?

bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-reboot] SKIPPED (warm reboot is not supported on dualtor)                                                                                                                                            [100%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-bgp_docker] PASSED                                                                                                                                                                                   [100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Longxiang <lolv@microsoft.com>
@lolyu lolyu requested a review from StormLiangMS as a code owner November 25, 2024 12:46
@lolyu lolyu requested a review from yxieca November 25, 2024 12:46
@lolyu lolyu requested a review from bingwang-ms November 25, 2024 12:51
@lipxu lipxu self-requested a review November 26, 2024 08:06
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit f61e4fe into sonic-net:master Nov 26, 2024
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 27, 2024
…et#15729)

What is the motivation for this PR?
Skip the warm reboot test type, as it will leave the DUT in an error state, and causes failures of following cases:

bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-bgp_docker] PASSED [ 16%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-swss_docker] PASSED [ 33%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-reboot] FAILED [ 50%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-bgp_docker] FAILED [ 66%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-swss_docker] FAILED [ 83%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-reboot] FAILED [100%]
Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?
If test type is reboot (warm reboot), skip on dualtor.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15767

mssonicbld pushed a commit that referenced this pull request Nov 27, 2024
What is the motivation for this PR?
Skip the warm reboot test type, as it will leave the DUT in an error state, and causes failures of following cases:

bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-bgp_docker] PASSED [ 16%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-swss_docker] PASSED [ 33%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[interface-reboot] FAILED [ 50%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-bgp_docker] FAILED [ 66%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-swss_docker] FAILED [ 83%]
bgp/test_bgp_session.py::test_bgp_session_interface_down[neighbor-reboot] FAILED [100%]
Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?
If test type is reboot (warm reboot), skip on dualtor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants